Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: Source/core/css/parser/CSSPropertyParser.h

Issue 184853009: Revert of Move all RefPtr's to CSSValue to oilpan transition types (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.h
diff --git a/Source/core/css/parser/CSSPropertyParser.h b/Source/core/css/parser/CSSPropertyParser.h
index 2b367369fa21a5270bdddf12a4aea2f4b0c675e0..6d065c356115e660bea0a3c54e0b66c653db12bc 100644
--- a/Source/core/css/parser/CSSPropertyParser.h
+++ b/Source/core/css/parser/CSSPropertyParser.h
@@ -62,11 +62,12 @@
// Outputs: Vector of CSSProperties
class CSSPropertyParser {
- STACK_ALLOCATED();
public:
+ typedef Vector<CSSProperty, 256> ParsedPropertyVector;
+
CSSPropertyParser(OwnPtr<CSSParserValueList>&,
const CSSParserContext&, bool inViewport, bool savedImportant,
- WillBeHeapVector<CSSProperty, 256>&, bool& hasFontFaceOnlyValues);
+ ParsedPropertyVector&, bool& hasFontFaceOnlyValues);
~CSSPropertyParser();
// FIXME: Should this be on a separate ColorParser object?
@@ -379,14 +380,14 @@
const bool m_important; // FIXME: This is only used by font-face-src and unicode-range and undoubtably wrong!
// Outputs:
- WillBeHeapVector<CSSProperty, 256>& m_parsedProperties;
+ ParsedPropertyVector& m_parsedProperties;
bool m_hasFontFaceOnlyValues;
// Locals during parsing:
int m_inParseShorthand;
CSSPropertyID m_currentShorthand;
bool m_implicitShorthand;
- RefPtrWillBeRawPtr<CSSCalcValue> m_parsedCalculation;
+ RefPtrWillBePersistent<CSSCalcValue> m_parsedCalculation;
// FIXME: There is probably a small set of APIs we could expose for these
// classes w/o needing to make them friends.
« no previous file with comments | « Source/core/css/parser/BisonCSSParser-in.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698