Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Side by Side Diff: Source/core/css/CSSProperty.cpp

Issue 184853009: Revert of Move all RefPtr's to CSSValue to oilpan transition types (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/CSSProperty.h ('k') | Source/core/css/CSSValue.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 3 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 29 matching lines...) Expand all
40 return CSSPropertyInvalid; 40 return CSSPropertyInvalid;
41 41
42 Vector<StylePropertyShorthand, 4> shorthands; 42 Vector<StylePropertyShorthand, 4> shorthands;
43 getMatchingShorthandsForLonghand(static_cast<CSSPropertyID>(m_propertyID), & shorthands); 43 getMatchingShorthandsForLonghand(static_cast<CSSPropertyID>(m_propertyID), & shorthands);
44 ASSERT(shorthands.size() && m_indexInShorthandsVector >= 0 && m_indexInShort handsVector < shorthands.size()); 44 ASSERT(shorthands.size() && m_indexInShorthandsVector >= 0 && m_indexInShort handsVector < shorthands.size());
45 return shorthands.at(m_indexInShorthandsVector).id(); 45 return shorthands.at(m_indexInShorthandsVector).id();
46 } 46 }
47 47
48 void CSSProperty::wrapValueInCommaSeparatedList() 48 void CSSProperty::wrapValueInCommaSeparatedList()
49 { 49 {
50 RefPtrWillBeRawPtr<CSSValue> value = m_value.release(); 50 RefPtr<CSSValue> value = m_value.release();
51 m_value = CSSValueList::createCommaSeparated(); 51 m_value = CSSValueList::createCommaSeparated();
52 toCSSValueList(m_value.get())->append(value.release()); 52 toCSSValueList(m_value.get())->append(value.release());
53 } 53 }
54 54
55 enum LogicalBoxSide { BeforeSide, EndSide, AfterSide, StartSide }; 55 enum LogicalBoxSide { BeforeSide, EndSide, AfterSide, StartSide };
56 enum PhysicalBoxSide { TopSide, RightSide, BottomSide, LeftSide }; 56 enum PhysicalBoxSide { TopSide, RightSide, BottomSide, LeftSide };
57 57
58 static CSSPropertyID resolveToPhysicalProperty(TextDirection direction, WritingM ode writingMode, LogicalBoxSide logicalSide, const StylePropertyShorthand& short hand) 58 static CSSPropertyID resolveToPhysicalProperty(TextDirection direction, WritingM ode writingMode, LogicalBoxSide logicalSide, const StylePropertyShorthand& short hand)
59 { 59 {
60 if (direction == LTR) { 60 if (direction == LTR) {
(...skipping 614 matching lines...) Expand 10 before | Expand all | Expand 10 after
675 return false; 675 return false;
676 case CSSPropertyInvalid: 676 case CSSPropertyInvalid:
677 ASSERT_NOT_REACHED(); 677 ASSERT_NOT_REACHED();
678 return false; 678 return false;
679 } 679 }
680 ASSERT_NOT_REACHED(); 680 ASSERT_NOT_REACHED();
681 return false; 681 return false;
682 } 682 }
683 683
684 } // namespace WebCore 684 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/CSSProperty.h ('k') | Source/core/css/CSSValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698