Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1848463002: Include the surrogate character count when updating text state (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include the surrogate character count when updating text state The subexpression at the end of walkInlineText() should include the number of surrogate pairs encountered - and hence match the expression used to update the character data map. If these don't match, text nodes following a text node which contains surrogate paris will have miscomputed value list positions (and fail to apply 'x', 'y' etc properly.) BUG=597312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/svg/text/surrogate-pair-attribute-positions.html View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/text/surrogate-pair-attribute-positions-expected.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
pdr.
I wrote the exact same patch before so you're definitely on to something! The non-bmp-tspans.svg ...
4 years, 8 months ago (2016-03-30 23:09:33 UTC) #2
fs
On 2016/03/30 at 23:09:33, pdr wrote: > I wrote the exact same patch before so ...
4 years, 8 months ago (2016-03-31 09:05:20 UTC) #3
pdr.
4 years, 8 months ago (2016-03-31 23:31:05 UTC) #4
Message was sent while issue was closed.
On 2016/03/31 at 09:05:20, fs wrote:
> On 2016/03/30 at 23:09:33, pdr wrote:
> > I wrote the exact same patch before so you're definitely on to something!
> > 
> > The non-bmp-tspans.svg failure seems real though. I didn't look into this
further once I hit that.
> 
> Yes, I noticed this, and have so far come to the conclusion that different
parts of the code account for the same thing using different units. I did not
intend to publish this (and I hope I didn't...), but rather close it - since
this will likely involve some shaving of a yak...

Yeah, this wasn't published. I just saw it in your queue looking for another
patch.

Powered by Google App Engine
This is Rietveld 408576698