Issue 1839413002: Simplify the computation of the value list position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1839413002: Simplify the computation of the value list position (Closed)

Created:
4 years, 8 months ago by fs

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, krit, f(malita), jchaffraix+rendering, blink-reviews, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-6

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Simplify the computation of the value list position The value list position is updated by one for each character, and not at all when spaces are skipped (collapsed). Currently this is achieved by using currentPosition (the offset in the text node, in code units) as the base and then subtract the number of skipped spaces and the number of surrogates. I.e +0 for skipped spaces and +1 for surrogates (which occupy two code units) and other characters. We can simplify this to a simple increment for every "full" trip of the iteration, and do away with the dependent counters. BUG=594058

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -10 lines)			Patch
	M	third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp	View		1 chunk	+4 lines, -10 lines	0 comments	Download

Depends on Patchset:

Issue 1848463002 Patch 1