Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1838363004: Pass LineLayoutSVGInlineText to SVGTextMetricsCalculator (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass LineLayoutSVGInlineText to SVGTextMetricsCalculator Slightly more on the Layout API bandwagon. BUG=594058 Committed: https://crrev.com/b44c6b7b5e08fcd235cabc068cb01d88210f4c74 Cr-Commit-Position: refs/heads/master@{#384137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp View 3 chunks +7 lines, -6 lines 0 comments Download

Dependent Patchsets:

Issue 1848463002 Patch 1

Messages

Total messages: 8 (3 generated)
fs
4 years, 8 months ago (2016-03-30 13:18:33 UTC) #2
pdr.
LGTM
4 years, 8 months ago (2016-03-30 23:06:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838363004/1
4 years, 8 months ago (2016-03-30 23:06:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 23:11:59 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 23:13:11 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b44c6b7b5e08fcd235cabc068cb01d88210f4c74
Cr-Commit-Position: refs/heads/master@{#384137}

Powered by Google App Engine
This is Rietveld 408576698