Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1848193002: Remove last 3 layout tests that expect NPAPI (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
Reviewers:
dcheng
CC:
blink-reviews, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove last 3 layout tests that expect NPAPI BUG=474535, 493212 Committed: https://crrev.com/b5d8c5fa02a3b75e28fab792246311d63adb1187 Cr-Commit-Position: refs/heads/master@{#384493}

Patch Set 1 #

Total comments: 4

Messages

Total messages: 14 (6 generated)
piman
4 years, 8 months ago (2016-04-01 04:14:49 UTC) #2
dcheng
https://codereview.chromium.org/1848193002/diff/1/third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html File third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html (right): https://codereview.chromium.org/1848193002/diff/1/third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html#newcode18 third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html:18: <object id="target" type="application/x-blink-test-plugin"></object> Should this be x-blink-deprecated-test-plugin? The regular ...
4 years, 8 months ago (2016-04-01 04:18:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848193002/1
4 years, 8 months ago (2016-04-01 04:21:45 UTC) #5
piman
https://codereview.chromium.org/1848193002/diff/1/third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html File third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html (right): https://codereview.chromium.org/1848193002/diff/1/third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html#newcode18 third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html:18: <object id="target" type="application/x-blink-test-plugin"></object> On 2016/04/01 04:18:58, dcheng wrote: > ...
4 years, 8 months ago (2016-04-01 04:22:01 UTC) #6
dcheng
lgtm https://codereview.chromium.org/1848193002/diff/1/third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html File third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html (right): https://codereview.chromium.org/1848193002/diff/1/third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html#newcode18 third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html:18: <object id="target" type="application/x-blink-test-plugin"></object> On 2016/04/01 at 04:22:01, piman ...
4 years, 8 months ago (2016-04-01 04:34:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848193002/1
4 years, 8 months ago (2016-04-01 04:40:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 05:38:32 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 05:39:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5d8c5fa02a3b75e28fab792246311d63adb1187
Cr-Commit-Position: refs/heads/master@{#384493}

Powered by Google App Engine
This is Rietveld 408576698