Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1852523003: Remove NPAPI test plugin (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_last_plugin_layout_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NPAPI test plugin Naga... Naga... Naga... Not gonna work here anymore, anyway. BUG=474535, 493212 Committed: https://crrev.com/ad12e38032364d671f9e746a0671422460442b6a Cr-Commit-Position: refs/heads/master@{#384728}

Patch Set 1 #

Patch Set 2 : fix isolate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5029 lines) Patch
M build/all.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser_tests.isolate View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_browsertests.isolate View 3 chunks +0 lines, -3 lines 0 comments Download
M content/content_shell.gypi View 2 chunks +0 lines, -99 lines 0 comments Download
M content/shell/BUILD.gn View 3 chunks +0 lines, -8 lines 0 comments Download
D content/shell/tools/plugin/PluginObject.h View 1 chunk +0 lines, -94 lines 0 comments Download
D content/shell/tools/plugin/PluginObject.cpp View 1 chunk +0 lines, -1490 lines 0 comments Download
D content/shell/tools/plugin/PluginTest.h View 1 chunk +0 lines, -302 lines 0 comments Download
D content/shell/tools/plugin/PluginTest.cpp View 1 chunk +0 lines, -265 lines 0 comments Download
D content/shell/tools/plugin/TestObject.cpp View 1 chunk +0 lines, -222 lines 0 comments Download
D content/shell/tools/plugin/Tests/EvaluateJSAfterRemovingPluginElement.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
D content/shell/tools/plugin/Tests/EvaluateJSWithinNPP_New.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D content/shell/tools/plugin/Tests/FormValue.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
D content/shell/tools/plugin/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
D content/shell/tools/plugin/Tests/InvokeDestroysPluginWithinNPP_New.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
D content/shell/tools/plugin/Tests/LeakWindowScriptableObject.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
D content/shell/tools/plugin/Tests/LogNPPSetWindow.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
D content/shell/tools/plugin/Tests/NPDeallocateCalledBeforeNPShutdown.cpp View 1 chunk +0 lines, -102 lines 0 comments Download
D content/shell/tools/plugin/Tests/NPPNewFails.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D content/shell/tools/plugin/Tests/NPPSetWindowCalledDuringDestruction.cpp View 1 chunk +0 lines, -131 lines 0 comments Download
D content/shell/tools/plugin/Tests/NPRuntimeCallsWithNullNPP.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
D content/shell/tools/plugin/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
D content/shell/tools/plugin/Tests/NPRuntimeRemoveProperty.cpp View 1 chunk +0 lines, -173 lines 0 comments Download
D content/shell/tools/plugin/Tests/NullNPPGetValuePointer.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D content/shell/tools/plugin/Tests/PassDifferentNPPStruct.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D content/shell/tools/plugin/Tests/PluginScriptableNPObjectInvokeDefault.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
D content/shell/tools/plugin/Tests/PluginScriptableObjectOverridesAllProperties.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
D content/shell/tools/plugin/Tests/SlowNPPNew.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
D content/shell/tools/plugin/mac/Info.plist View 1 chunk +0 lines, -60 lines 0 comments Download
D content/shell/tools/plugin/main.cpp View 1 chunk +0 lines, -853 lines 0 comments Download
D content/shell/tools/plugin/test_object.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/shell/tools/plugin/win/TestNetscapePlugin.def View 1 chunk +0 lines, -6 lines 0 comments Download
D content/shell/tools/plugin/win/TestNetscapePlugin.rc View 1 chunk +0 lines, -102 lines 0 comments Download
D content/shell/tools/plugin/win/TestNetscapePlugin_debug.def View 1 chunk +0 lines, -6 lines 0 comments Download
D content/shell/tools/plugin/win/resource.h View 1 chunk +0 lines, -18 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
piman
dcheng: please review dpranke: build/, components/test_runner/ maruel: browser_tests.isolate
4 years, 8 months ago (2016-04-01 04:36:11 UTC) #2
dcheng
LGTM!!! \(^o^)/
4 years, 8 months ago (2016-04-01 04:43:03 UTC) #3
M-A Ruel
Chrome Finally. Glad it's not an April fools. lgtm
4 years, 8 months ago (2016-04-01 19:13:24 UTC) #4
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-01 22:42:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852523003/20001
4 years, 8 months ago (2016-04-01 23:20:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-01 23:54:15 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 23:56:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad12e38032364d671f9e746a0671422460442b6a
Cr-Commit-Position: refs/heads/master@{#384728}

Powered by Google App Engine
This is Rietveld 408576698