third_party/WebKit/LayoutTests/editing/selection/selection-plugin-clear-crash.html - Issue 1848193002: Remove last 3 layout tests that expect NPAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/selection/selection-plugin-clear-crash.html

Issue 1848193002: Remove last 3 layout tests that expect NPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/tests/blink_deprecated_test_plugin.cc ('k') | third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html » ('j') | third_party/WebKit/LayoutTests/plugins/createScriptableObject-before-start.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/selection/selection-plugin-clear-crash.html

diff --git a/third_party/WebKit/LayoutTests/editing/selection/selection-plugin-clear-crash.html b/third_party/WebKit/LayoutTests/editing/selection/selection-plugin-clear-crash.html

index fc66b5e2b98e57c923d7b66f03b44082b85bbaec..623e49d882ce8f91e6062ea1747e52bafe3ce78d 100644

--- a/third_party/WebKit/LayoutTests/editing/selection/selection-plugin-clear-crash.html

+++ b/third_party/WebKit/LayoutTests/editing/selection/selection-plugin-clear-crash.html

@@ -8,10 +8,7 @@ function runTest()

{

var obj = document.getElementById("test");

var s = window.getSelection();

- // The cleardocumentduringnew attribute intends to clear document.body when the

- // embed element is loaded and it is used for only tests. See:

- // https://code.google.com/p/chromium/codesearch#chromium/src/content/shell/tools/plugin/main.cpp&q=cleardocumentduringnew&type=cs&sq=package:chromium&l=247

- // It causes a timing issue that |obj| exists on Linux but not on Windows.

+ // The initscript attribute is run (synchronously) when the plugin is created.

if (obj)

s.collapse(obj, 0);

else

@@ -22,7 +19,7 @@ function runTest()

<div>

-<embed type="application/x-webkit-test-netscape" cleardocumentduringnew></embed>

+<embed type="application/x-blink-deprecated-test-plugin" initscript="document.body.innerHTML = '';"></embed>

</div>

</body>

</html>