Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1847963003: Update vulkan format features in caps. (Closed)

Created:
4 years, 8 months ago by egdaniel
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : review nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -140 lines) Patch
M src/gpu/vk/GrVkCaps.h View 1 2 2 chunks +43 lines, -29 lines 0 comments Download
M src/gpu/vk/GrVkCaps.cpp View 1 2 2 chunks +56 lines, -109 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/vk/GrVkImage.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkSampler.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
egdaniel
4 years, 8 months ago (2016-03-31 20:49:21 UTC) #3
jvanverth1
lgtm + one spelling correction https://codereview.chromium.org/1847963003/diff/20001/src/gpu/vk/GrVkCaps.h File src/gpu/vk/GrVkCaps.h (right): https://codereview.chromium.org/1847963003/diff/20001/src/gpu/vk/GrVkCaps.h#newcode106 src/gpu/vk/GrVkCaps.h:106: uint16_t fOptimimalFlags; fOptimalFlags
4 years, 8 months ago (2016-04-01 13:30:20 UTC) #4
bsalomon
lgtm, too
4 years, 8 months ago (2016-04-01 13:45:30 UTC) #5
egdaniel
https://codereview.chromium.org/1847963003/diff/20001/src/gpu/vk/GrVkCaps.h File src/gpu/vk/GrVkCaps.h (right): https://codereview.chromium.org/1847963003/diff/20001/src/gpu/vk/GrVkCaps.h#newcode106 src/gpu/vk/GrVkCaps.h:106: uint16_t fOptimimalFlags; On 2016/04/01 13:30:20, jvanverth1 wrote: > fOptimalFlags ...
4 years, 8 months ago (2016-04-01 16:59:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847963003/40001
4 years, 8 months ago (2016-04-01 16:59:12 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 17:10:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8f1dcaa6f3cc098bd5efd2595ca20e0bc1847d10

Powered by Google App Engine
This is Rietveld 408576698