src/gpu/vk/GrVkGpu.cpp - Issue 1847963003: Update vulkan format features in caps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkGpu.cpp

Issue 1847963003: Update vulkan format features in caps. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: review nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkGpu.cpp

diff --git a/src/gpu/vk/GrVkGpu.cpp b/src/gpu/vk/GrVkGpu.cpp

index de1e9052fa4870ee44e5b40fdc6c0da5c0b03c62..55f1eae99739220f56014aade32cada9fab47598 100644

--- a/src/gpu/vk/GrVkGpu.cpp

+++ b/src/gpu/vk/GrVkGpu.cpp

@@ -650,8 +650,7 @@ GrStencilAttachment* GrVkGpu::createStencilAttachmentForRenderTarget(const GrRen

int samples = rt->numStencilSamples();

- SkASSERT(this->vkCaps().stencilFormats().count());

- const GrVkCaps::StencilFormat& sFmt = this->vkCaps().stencilFormats()[0];

+ const GrVkCaps::StencilFormat& sFmt = this->vkCaps().preferedStencilFormat();

GrVkStencilAttachment* stencil(GrVkStencilAttachment::Create(this,

GrGpuResource::kCached_LifeCycle,

« no previous file with comments | « src/gpu/vk/GrVkCaps.cpp ('k') | src/gpu/vk/GrVkImage.cpp » ('j') | no next file with comments »