Extract WebFrameClient implementation out of WebTestProxyBase.

Extract WebFrameClient implementation out of WebTestProxyBase.

Overview
========

This CL extracts WebFrameClient-specific parts of WebTestProxyBase into
a new WebFrameTestClient class.

This CL is part of a sequence of CLs that make progress toward:

1) Splitting WebTestProxyBase into separate WebFrameClient /
   WebWidgetClient / WebViewClient focused classes

2) Removing WebTestProxyBase from public API of components/test_runner
   (and having WebTestProxy and WebFrameTestProxy consume instead
   abstract WebFrameClient / WebWidgetClient / WebViewClient interfaces).

Details
=======

Most of the change is mechanical move of code from WebTestProxyBase
into the new WebFrameTestClient (slightly tweaking method signatures
as needed to make them fit WebFrameClient interface - note camelCasing
and extra parameters here and there).

Additionally some helper methods (i.e. URLDescription and
WebNavigationPolicyToString) are now needed by both WebTestProxyBase and
by WebFrameTestClient.  Consequently, to facilitate code reuse, these
helper methods were moved to test_common.cc.

Finally, in order to decouple WebFrameTestClient from view-specific
WebTestProxyBase the CL does the following:

- It moves counting currently active color choosers from
  WebTestProxyBase into TestRunner (and adjusts MockColorChooser
  accordingly).

- It moves ownership of MockWebUserMediaClient from
  WebTestProxyBase into TestRunner.  This is quite natural, as
  MockWebUserMediaClient depends only on WebTestDelegate::PostTask and
  WebTestDelegate::AddMediaStreamAudioSourceAndTrack (which are not
  view-specific).

- Replacing WebFrameTestProxy::set_base_proxy with
  WebFrameTestProxy::set_test_client requires refactoring how higher
  layers provide the necessary object - in particular after the CL the
  WebFrame[Test]Client cannot be extracted from WebTestProxy/RenderView
  (because the whole point of this CL is to remove the coupling between
  view-specific WebTestProxy and frame-focused WebFrameTestProxy).  This
  part of the refactoring is accomplished by adding a frame-proxy
  creation callback that can be provided to EnableWebTestProxyCreation
  (similarily how it already was accepting equivalent view-proxy
  creation callback).  This refactoring also necessitates extracting a
  WebFrameTestProxyBase (to have a concrete/non-templatized type that
  content/shell/.../layout_tests layer can take a dependency on).

BUG=595089
Committed: https://crrev.com/fd1246076d86b2b9245bb808e7d9a25867256b96
Cr-Commit-Position: refs/heads/master@{#384609}

[Łukasz Anforowicz, 2016-03-31 18:56:09]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-31 18:56:10]

jochen@, can you take a look please?

This is basically https://crrev.com/1821923003, but with UaF fixed.  The fix was
to basically undo unnecessary changes to MockColorChooser::endChooser and
MockColorChooser::InvokeDidEndChooser that were present in the original CL.

I've also added a DCHECK around manipulation of TestRunner::chooser_count_ and
discovered with it that I was miscounting because of the unnecessary zeroing of
the count in TestRunner::Reset.

[jochen (gone - plz use gerrit), 2016-04-01 08:44:04]

lgtm

[Łukasz Anforowicz, 2016-04-01 16:15:07]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-01 16:15:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847893002/20001

[commit-bot: I haz the power, 2016-04-01 16:53:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-01 16:55:11]

Description was changed from

==========
Extract WebFrameClient implementation out of WebTestProxyBase.

Overview
========

This CL extracts WebFrameClient-specific parts of WebTestProxyBase into
a new WebFrameTestClient class.

This CL is part of a sequence of CLs that make progress toward:

1) Splitting WebTestProxyBase into separate WebFrameClient /
   WebWidgetClient / WebViewClient focused classes

2) Removing WebTestProxyBase from public API of components/test_runner
   (and having WebTestProxy and WebFrameTestProxy consume instead
   abstract WebFrameClient / WebWidgetClient / WebViewClient interfaces).

Details
=======

Most of the change is mechanical move of code from WebTestProxyBase
into the new WebFrameTestClient (slightly tweaking method signatures
as needed to make them fit WebFrameClient interface - note camelCasing
and extra parameters here and there).

Additionally some helper methods (i.e. URLDescription and
WebNavigationPolicyToString) are now needed by both WebTestProxyBase and
by WebFrameTestClient.  Consequently, to facilitate code reuse, these
helper methods were moved to test_common.cc.

Finally, in order to decouple WebFrameTestClient from view-specific
WebTestProxyBase the CL does the following:

- It moves counting currently active color choosers from
  WebTestProxyBase into TestRunner (and adjusts MockColorChooser
  accordingly).

- It moves ownership of MockWebUserMediaClient from
  WebTestProxyBase into TestRunner.  This is quite natural, as
  MockWebUserMediaClient depends only on WebTestDelegate::PostTask and
  WebTestDelegate::AddMediaStreamAudioSourceAndTrack (which are not
  view-specific).

- Replacing WebFrameTestProxy::set_base_proxy with
  WebFrameTestProxy::set_test_client requires refactoring how higher
  layers provide the necessary object - in particular after the CL the
  WebFrame[Test]Client cannot be extracted from WebTestProxy/RenderView
  (because the whole point of this CL is to remove the coupling between
  view-specific WebTestProxy and frame-focused WebFrameTestProxy).  This
  part of the refactoring is accomplished by adding a frame-proxy
  creation callback that can be provided to EnableWebTestProxyCreation
  (similarily how it already was accepting equivalent view-proxy
  creation callback).  This refactoring also necessitates extracting a
  WebFrameTestProxyBase (to have a concrete/non-templatized type that
  content/shell/.../layout_tests layer can take a dependency on).

BUG=595089
==========

to

==========
Extract WebFrameClient implementation out of WebTestProxyBase.

Overview
========

This CL extracts WebFrameClient-specific parts of WebTestProxyBase into
a new WebFrameTestClient class.

This CL is part of a sequence of CLs that make progress toward:

1) Splitting WebTestProxyBase into separate WebFrameClient /
   WebWidgetClient / WebViewClient focused classes

2) Removing WebTestProxyBase from public API of components/test_runner
   (and having WebTestProxy and WebFrameTestProxy consume instead
   abstract WebFrameClient / WebWidgetClient / WebViewClient interfaces).

Details
=======

Most of the change is mechanical move of code from WebTestProxyBase
into the new WebFrameTestClient (slightly tweaking method signatures
as needed to make them fit WebFrameClient interface - note camelCasing
and extra parameters here and there).

Additionally some helper methods (i.e. URLDescription and
WebNavigationPolicyToString) are now needed by both WebTestProxyBase and
by WebFrameTestClient.  Consequently, to facilitate code reuse, these
helper methods were moved to test_common.cc.

Finally, in order to decouple WebFrameTestClient from view-specific
WebTestProxyBase the CL does the following:

- It moves counting currently active color choosers from
  WebTestProxyBase into TestRunner (and adjusts MockColorChooser
  accordingly).

- It moves ownership of MockWebUserMediaClient from
  WebTestProxyBase into TestRunner.  This is quite natural, as
  MockWebUserMediaClient depends only on WebTestDelegate::PostTask and
  WebTestDelegate::AddMediaStreamAudioSourceAndTrack (which are not
  view-specific).

- Replacing WebFrameTestProxy::set_base_proxy with
  WebFrameTestProxy::set_test_client requires refactoring how higher
  layers provide the necessary object - in particular after the CL the
  WebFrame[Test]Client cannot be extracted from WebTestProxy/RenderView
  (because the whole point of this CL is to remove the coupling between
  view-specific WebTestProxy and frame-focused WebFrameTestProxy).  This
  part of the refactoring is accomplished by adding a frame-proxy
  creation callback that can be provided to EnableWebTestProxyCreation
  (similarily how it already was accepting equivalent view-proxy
  creation callback).  This refactoring also necessitates extracting a
  WebFrameTestProxyBase (to have a concrete/non-templatized type that
  content/shell/.../layout_tests layer can take a dependency on).

BUG=595089

Committed: https://crrev.com/fd1246076d86b2b9245bb808e7d9a25867256b96
Cr-Commit-Position: refs/heads/master@{#384609}
==========

[commit-bot: I haz the power, 2016-04-01 16:55:12]

Patchset 2 (id:??) landed as
https://crrev.com/fd1246076d86b2b9245bb808e7d9a25867256b96
Cr-Commit-Position: refs/heads/master@{#384609}