Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: components/test_runner/web_test_interfaces.h

Issue 1847893002: Extract WebFrameClient implementation out of WebTestProxyBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert some changes to mock_color_chooser.cc + fix counting of TestRunner::chooser_count_. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_frame_test_proxy.h ('k') | components/test_runner/web_test_interfaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_test_interfaces.h
diff --git a/components/test_runner/web_test_interfaces.h b/components/test_runner/web_test_interfaces.h
index a163c44558e0560f9823568ed90f4ad3ed2bebda..481c4261f952eb1b87a87e6ce8f28255e9c99de1 100644
--- a/components/test_runner/web_test_interfaces.h
+++ b/components/test_runner/web_test_interfaces.h
@@ -13,6 +13,7 @@ namespace blink {
class WebAppBannerClient;
class WebAudioDevice;
class WebFrame;
+class WebFrameClient;
class WebMediaStreamCenter;
class WebMediaStreamCenterClient;
class WebMIDIAccessor;
@@ -28,6 +29,7 @@ namespace test_runner {
class AppBannerClient;
class TestInterfaces;
+class WebFrameTestClient;
class WebTestDelegate;
class WebTestProxyBase;
class WebTestRunner;
@@ -64,8 +66,15 @@ class TEST_RUNNER_EXPORT WebTestInterfaces {
TestInterfaces* GetTestInterfaces();
+ // Gets a borrowed pointer to a WebFrameClient implementation providing
+ // test behavior (i.e. forwarding javascript console output to the test
+ // harness). The caller should guarantee that the returned pointer
+ // won't be used beyond the lifetime of WebTestInterfaces.
+ blink::WebFrameClient* GetWebFrameTestClient();
+
private:
scoped_ptr<TestInterfaces> interfaces_;
+ scoped_ptr<WebFrameTestClient> web_frame_test_client_;
DISALLOW_COPY_AND_ASSIGN(WebTestInterfaces);
};
« no previous file with comments | « components/test_runner/web_frame_test_proxy.h ('k') | components/test_runner/web_test_interfaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698