Add error callback to net::CertificateReportSender

Add error callback to net::CertificateReportSender

We want to start recording UMA metrics (and perhaps eventually taking
other actions such as retrying) when various types of certificate
reports fail to send. This CL adds an error callback to the
net::CertificateReportSender class to allow us to do this.

It also fixes a small bug where apparently we were printing a log
message about reports failing to send even when they succeeded.

BUG=596624
Committed: https://crrev.com/b2288ecde37cbe28ac295607f8686906f1c618e8
Cr-Commit-Position: refs/heads/master@{#384402}

[estark, 2016-03-31 00:39:28]

estark@chromium.org changed reviewers:
+ eroman@chromium.org

[estark, 2016-03-31 00:39:29]

Hi eroman, could you take a look please?

[eroman, 2016-03-31 00:55:41]

lgtm

https://codereview.chromium.org/1847563004/diff/1/net/url_request/certificate...
File net/url_request/certificate_report_sender.cc (right):

https://codereview.chromium.org/1847563004/diff/1/net/url_request/certificate...
net/url_request/certificate_report_sender.cc:22: :
request_context_(request_context),
I suggest forwarding this to the new ctor:

  : CertificateReportSender(request_context, cookies_preference, <null
callback>) {}

[estark, 2016-03-31 01:30:46]

https://codereview.chromium.org/1847563004/diff/1/net/url_request/certificate...
File net/url_request/certificate_report_sender.cc (right):

https://codereview.chromium.org/1847563004/diff/1/net/url_request/certificate...
net/url_request/certificate_report_sender.cc:22: :
request_context_(request_context),
On 2016/03/31 00:55:41, eroman wrote:
> I suggest forwarding this to the new ctor:
> 
>   : CertificateReportSender(request_context, cookies_preference, <null
> callback>) {}

Done.

[estark, 2016-03-31 01:30:49]

The CQ bit was checked by estark@chromium.org

[estark, 2016-03-31 01:30:49]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1847563004/#ps20001
(title: "eroman comment")

[commit-bot: I haz the power, 2016-03-31 01:31:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847563004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847563004/20001

[commit-bot: I haz the power, 2016-03-31 02:09:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 02:09:14]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estark, 2016-03-31 04:59:15]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-03-31 04:59:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847563004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847563004/20001

[commit-bot: I haz the power, 2016-03-31 07:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 07:48:20]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[estark, 2016-03-31 20:43:35]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-03-31 20:44:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847563004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847563004/20001

[commit-bot: I haz the power, 2016-03-31 21:45:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 21:46:37]

Description was changed from

==========
Add error callback to net::CertificateReportSender

We want to start recording UMA metrics (and perhaps eventually taking
other actions such as retrying) when various types of certificate
reports fail to send. This CL adds an error callback to the
net::CertificateReportSender class to allow us to do this.

It also fixes a small bug where apparently we were printing a log
message about reports failing to send even when they succeeded.

BUG=596624
==========

to

==========
Add error callback to net::CertificateReportSender

We want to start recording UMA metrics (and perhaps eventually taking
other actions such as retrying) when various types of certificate
reports fail to send. This CL adds an error callback to the
net::CertificateReportSender class to allow us to do this.

It also fixes a small bug where apparently we were printing a log
message about reports failing to send even when they succeeded.

BUG=596624

Committed: https://crrev.com/b2288ecde37cbe28ac295607f8686906f1c618e8
Cr-Commit-Position: refs/heads/master@{#384402}
==========

[commit-bot: I haz the power, 2016-03-31 21:46:38]

Patchset 2 (id:??) landed as
https://crrev.com/b2288ecde37cbe28ac295607f8686906f1c618e8
Cr-Commit-Position: refs/heads/master@{#384402}