Add error callback to net::CertificateReportSender

net/url_request/certificate_report_sender_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/certificate_report_sender.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 29 matching lines @@
   ASSERT_EQ(1u, upload->GetElementReaders()->size());
 
   const UploadBytesElementReader* reader =
       (*upload->GetElementReaders())[0]->AsBytesReader();
   ASSERT_TRUE(reader);
   std::string upload_data(reader->bytes(), reader->length());
 
   EXPECT_EQ(1u, expect_reports->erase(upload_data));
 }
 
+// Provides an error callback for report sending. If the callback is
+// called, it sets |called| to true.
+void ErrorCallback(bool* called, URLRequest* request) {
+  EXPECT_FALSE(request->status().is_success());
+  *called = true;
+}
+
 // A network delegate that lets tests check that a certificate report
 // was sent. It counts the number of requests and lets tests register a
 // callback to run when the request is destroyed. It also checks that
 // the uploaded data is as expected.
 class TestCertificateReportSenderNetworkDelegate : public NetworkDelegateImpl {
  public:
   TestCertificateReportSenderNetworkDelegate()
       : url_request_destroyed_callback_(base::Bind(&base::DoNothing)),
         all_url_requests_destroyed_callback_(base::Bind(&base::DoNothing)),
         num_requests_(0),
@@ skipping 171 matching lines @@
 
 // Test that a request that returns an error gets cleaned up.
 TEST_F(CertificateReportSenderTest, ErroredRequestGetsDeleted) {
   GURL url = URLRequestFailedJob::GetMockHttpsUrl(ERR_FAILED);
   CertificateReportSender reporter(
       context(), CertificateReportSender::DO_NOT_SEND_COOKIES);
   // SendReport will block until the URLRequest is destroyed.
   SendReport(&reporter, kDummyReport, url, 0);
 }
 
+// Test that the error callback, if provided, gets called when a request
+// returns an error.
+TEST_F(CertificateReportSenderTest, ErroredRequestCallsCallback) {
+  bool error_callback_called = false;
+  GURL url = URLRequestFailedJob::GetMockHttpsUrl(ERR_FAILED);
+  CertificateReportSender reporter(
+      context(), CertificateReportSender::DO_NOT_SEND_COOKIES,
+      base::Bind(ErrorCallback, &error_callback_called));
+  // SendReport will block until the URLRequest is destroyed.
+  SendReport(&reporter, kDummyReport, url, 0);
+  EXPECT_TRUE(error_callback_called);
+}
+
+// Test that the error callback does not get called when a request
+// does not return an error.
+TEST_F(CertificateReportSenderTest, SuccessfulRequestDoesNotCallErrorCallback) {
+  bool error_callback_called = false;
+  GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
+  CertificateReportSender reporter(
+      context(), CertificateReportSender::DO_NOT_SEND_COOKIES,
+      base::Bind(ErrorCallback, &error_callback_called));
+  SendReport(&reporter, kDummyReport, url, 0);
+  EXPECT_FALSE(error_callback_called);
+}
+
 // Test that cookies are sent or not sent according to the error
 // reporter's cookies preference.
 
 TEST_F(CertificateReportSenderTest, SendCookiesPreference) {
   GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
   CertificateReportSender reporter(context(),
                                    CertificateReportSender::SEND_COOKIES);
 
   network_delegate_.set_expect_cookies(true);
   SendReport(&reporter, kDummyReport, url, 0);
 }
 
 TEST_F(CertificateReportSenderTest, DoNotSendCookiesPreference) {
   GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
   CertificateReportSender reporter(
       context(), CertificateReportSender::DO_NOT_SEND_COOKIES);
 
   network_delegate_.set_expect_cookies(false);
   SendReport(&reporter, kDummyReport, url, 0);
 }
 
 }  // namespace
 }  // namespace net