Add error callback to net::CertificateReportSender

net/url_request/certificate_report_sender.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/certificate_report_sender.h"
 
 #include <utility>
 
 #include "base/stl_util.h"
 #include "net/base/elements_upload_data_stream.h"
 #include "net/base/load_flags.h"
 #include "net/base/request_priority.h"
 #include "net/base/upload_bytes_element_reader.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_status.h"
 
 namespace net {
 
 CertificateReportSender::CertificateReportSender(
     URLRequestContext* request_context,
     CookiesPreference cookies_preference)
     : request_context_(request_context),

[eroman, 2016/03/31 00:55:41]

I suggest forwarding this to the new ctor:

  : CertificateReportSender(request_context, cookies_preference, <null
callback>) {}

[estark, 2016/03/31 01:30:46]

Done.

       cookies_preference_(cookies_preference) {}
 
+CertificateReportSender::CertificateReportSender(
+    URLRequestContext* request_context,
+    CookiesPreference cookies_preference,
+    const base::Callback<void(URLRequest*)>& error_callback)
+    : request_context_(request_context),
+      cookies_preference_(cookies_preference),
+      error_callback_(error_callback) {}
+
 CertificateReportSender::~CertificateReportSender() {
   // Cancel all of the uncompleted requests.
   STLDeleteElements(&inflight_requests_);
 }
 
 void CertificateReportSender::Send(const GURL& report_uri,
                                    const std::string& report) {
   scoped_ptr<URLRequest> url_request =
       request_context_->CreateRequest(report_uri, DEFAULT_PRIORITY, this);
 
@@ skipping 10 matching lines @@
       UploadOwnedBytesElementReader::CreateWithString(report));
   url_request->set_upload(
       ElementsUploadDataStream::CreateWithReader(std::move(reader), 0));
 
   URLRequest* raw_url_request = url_request.get();
   inflight_requests_.insert(url_request.release());
   raw_url_request->Start();
 }
 
 void CertificateReportSender::OnResponseStarted(URLRequest* request) {
-  // TODO(estark): call a callback so that the caller can print a
-  // warning on failure.
-  DVLOG(1) << "Failed to send certificate report for " << request->url().host();
+  if (!request->status().is_success()) {
+    DVLOG(1) << "Failed to send certificate report for "
+             << request->url().host();
+    if (!error_callback_.is_null())
+      error_callback_.Run(request);
+  }
 
   CHECK_GT(inflight_requests_.erase(request), 0u);
   // Clean up the request, which cancels it.
   delete request;
 }
 
 void CertificateReportSender::OnReadCompleted(URLRequest* request,
                                               int bytes_read) {
   NOTREACHED();
 }
 
 }  // namespace net