cc/resources/resource_provider.cc - Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/resource_provider.cc

Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert changes to media unittests til we understand valgrind errors Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/resource_provider.cc

diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc

index 123d7f43d335b07fceb969dc2d3b8ea17f7a57a3..3c9ec8acf359cca2a2cfadcae45508e4528ec2ff 100644

--- a/cc/resources/resource_provider.cc

+++ b/cc/resources/resource_provider.cc

@@ -495,9 +495,7 @@ SkCanvas* ResourceProvider::BitmapRasterBuffer::DoLockForWrite() {

NOTREACHED();

break;

}

- skia::RefPtr<SkBitmapDevice> device =

- skia::AdoptRef(new SkBitmapDevice(raster_bitmap_));

- raster_canvas_ = skia::AdoptRef(new SkCanvas(device.get()));

+ raster_canvas_ = skia::AdoptRef(new SkCanvas(raster_bitmap_));

raster_bitmap_generation_id_ = raster_bitmap_.getGenerationID();

return raster_canvas_.get();

}

« no previous file with comments | « cc/output/gl_renderer.cc ('k') | chrome/browser/extensions/extension_action.cc » ('j') | no next file with comments »