cc/output/gl_renderer.cc - Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/gl_renderer.cc

Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert changes to media unittests til we understand valgrind errors Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/gl_renderer.cc

diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc

index 45b4a4fc4cc93bde8791ae332f35bdcafdaa1f18..a262e370a204685bf660c9c3110c912890882a14 100644

--- a/cc/output/gl_renderer.cc

+++ b/cc/output/gl_renderer.cc

@@ -95,8 +95,7 @@ class OnDemandRasterTaskImpl : public internal::Task {

// Overridden from internal::Task:

virtual void RunOnWorkerThread(unsigned thread_index) OVERRIDE {

TRACE_EVENT0("cc", "OnDemandRasterTaskImpl::RunOnWorkerThread");

- SkBitmapDevice device(*bitmap_);

- SkCanvas canvas(&device);

+ SkCanvas canvas(*bitmap_);

picture_pile_->RasterToBitmap(

&canvas, content_rect_, contents_scale_, NULL);

}

« no previous file with comments | « android_webview/native/java_browser_view_renderer_helper.cc ('k') | cc/resources/resource_provider.cc » ('j') | no next file with comments »