chrome/browser/extensions/extension_action.cc - Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 184743002: don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: revert changes to media unittests til we understand valgrind errors Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_action.cc

diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc

index f4f70471ac1cf073b5146f575f41e477a81a2946..c879636cbb490c5ae87ccaced6aa544676674596 100644

--- a/chrome/browser/extensions/extension_action.cc

+++ b/chrome/browser/extensions/extension_action.cc

@@ -15,7 +15,6 @@

#include "grit/theme_resources.h"

#include "grit/ui_resources.h"

#include "third_party/skia/include/core/SkBitmap.h"

-#include "third_party/skia/include/core/SkBitmapDevice.h"

#include "third_party/skia/include/core/SkCanvas.h"

#include "third_party/skia/include/core/SkPaint.h"

#include "third_party/skia/include/effects/SkGradientShader.h"

« no previous file with comments | « cc/resources/resource_provider.cc ('k') | content/browser/compositor/software_output_device_ozone.cc » ('j') | no next file with comments »