Use interface associations to check function permissions.

Use interface associations to check function permissions.

This patch expands on r383543 to use correctly use the interface
associations parsed out of device descriptors to allow WebUSB
access controls to be specified at a function, rather than interface,
level.

BUG=492204
TBR=pfeldman@chromium.org

Committed: https://crrev.com/1f45f77b4fa4afef5b1abeda6bfed21485630d90
Cr-Commit-Position: refs/heads/master@{#384785}

[Reilly Grant (use Gerrit), 2016-03-31 20:48:13]

reillyg@chromium.org changed reviewers:
+ juncai@chromium.org

[Reilly Grant (use Gerrit), 2016-03-31 20:48:13]

Please take a look.

[Reilly Grant (use Gerrit), 2016-03-31 20:48:18]

Please take a look.

[juncai, 2016-04-01 16:49:41]

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/device_impl.cc
File device/usb/mojo/device_impl.cc (right):

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/device_impl...
device/usb/mojo/device_impl.cc:174: [index](const UsbInterfaceDescriptor&
interface) {
This |interface| has the same name as the above:
const UsbInterfaceDescriptor* interface;
maybe better to give it a different name?

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/mock_permis...
File device/usb/mojo/mock_permission_provider.h (right):

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:5: #ifndef
DEVICE_USB_FAKE_PERMISSION_PROVIDER_H_
DEVICE_USB_FAKE_PERMISSION_PROVIDER_H_ ->
DEVICE_USB_MOJO_MOCK_PERMISSION_PROVIDER_H_

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:6: #define
DEVICE_USB_FAKE_PERMISSION_PROVIDER_H_
ditto

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:39: #endif  //
DEVICE_USB_FAKE_PERMISSION_PROVIDER_H_
ditto

[Reilly Grant (use Gerrit), 2016-04-01 21:46:57]

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/device_impl.cc
File device/usb/mojo/device_impl.cc (right):

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/device_impl...
device/usb/mojo/device_impl.cc:174: [index](const UsbInterfaceDescriptor&
interface) {
On 2016/04/01 at 16:49:41, juncai wrote:
> This |interface| has the same name as the above:
> const UsbInterfaceDescriptor* interface;
> maybe better to give it a different name?

Done.

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/mock_permis...
File device/usb/mojo/mock_permission_provider.h (right):

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:5: #ifndef
DEVICE_USB_FAKE_PERMISSION_PROVIDER_H_
On 2016/04/01 at 16:49:41, juncai wrote:
> DEVICE_USB_FAKE_PERMISSION_PROVIDER_H_ ->
> DEVICE_USB_MOJO_MOCK_PERMISSION_PROVIDER_H_

Done.

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:6: #define
DEVICE_USB_FAKE_PERMISSION_PROVIDER_H_
On 2016/04/01 at 16:49:41, juncai wrote:
> ditto

Done.

https://codereview.chromium.org/1847183002/diff/1/device/usb/mojo/mock_permis...
device/usb/mojo/mock_permission_provider.h:39: #endif  //
DEVICE_USB_FAKE_PERMISSION_PROVIDER_H_
On 2016/04/01 at 16:49:41, juncai wrote:
> ditto

Done.

[juncai, 2016-04-02 00:16:04]

LGTM with nit.

https://codereview.chromium.org/1847183002/diff/20001/device/usb/mojo/mock_pe...
File device/usb/mojo/mock_permission_provider.h (right):

https://codereview.chromium.org/1847183002/diff/20001/device/usb/mojo/mock_pe...
device/usb/mojo/mock_permission_provider.h:5: #ifndef
DEVICE_USB_MOCK_PERMISSION_PROVIDER_H_
nit: add "_MOJO" substring to the include guard:
DEVICE_USB_MOJO_MOCK_PERMISSION_PROVIDER_H_

[Reilly Grant (use Gerrit), 2016-04-02 01:35:45]

https://codereview.chromium.org/1847183002/diff/20001/device/usb/mojo/mock_pe...
File device/usb/mojo/mock_permission_provider.h (right):

https://codereview.chromium.org/1847183002/diff/20001/device/usb/mojo/mock_pe...
device/usb/mojo/mock_permission_provider.h:5: #ifndef
DEVICE_USB_MOCK_PERMISSION_PROVIDER_H_
On 2016/04/02 at 00:16:04, juncai wrote:
> nit: add "_MOJO" substring to the include guard:
> DEVICE_USB_MOJO_MOCK_PERMISSION_PROVIDER_H_

Done.

[Reilly Grant (use Gerrit), 2016-04-02 01:35:55]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-04-02 01:35:56]

The patchset sent to the CQ was uploaded after l-g-t-m from juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/1847183002/#ps40001
(title: "Addressed nit and fixed Windows build.")

[commit-bot: I haz the power, 2016-04-02 01:36:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847183002/40001

[commit-bot: I haz the power, 2016-04-02 01:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-02 01:46:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Reilly Grant (use Gerrit), 2016-04-02 01:46:35]

Description was changed from

==========
Use interface associations to check function permissions.

This patch expands on r383543 to use correctly use the interface
associations parsed out of device descriptors to allow WebUSB
access controls to be specified at a function, rather than interface,
level.

BUG=492204
==========

to

==========
Use interface associations to check function permissions.

This patch expands on r383543 to use correctly use the interface
associations parsed out of device descriptors to allow WebUSB
access controls to be specified at a function, rather than interface,
level.

BUG=492204
TBR=pfeldman@chromium.org
==========

[Reilly Grant (use Gerrit), 2016-04-02 01:46:40]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-04-02 01:46:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847183002/40001

[commit-bot: I haz the power, 2016-04-02 02:47:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-02 02:48:15]

Description was changed from

==========
Use interface associations to check function permissions.

This patch expands on r383543 to use correctly use the interface
associations parsed out of device descriptors to allow WebUSB
access controls to be specified at a function, rather than interface,
level.

BUG=492204
TBR=pfeldman@chromium.org
==========

to

==========
Use interface associations to check function permissions.

This patch expands on r383543 to use correctly use the interface
associations parsed out of device descriptors to allow WebUSB
access controls to be specified at a function, rather than interface,
level.

BUG=492204
TBR=pfeldman@chromium.org

Committed: https://crrev.com/1f45f77b4fa4afef5b1abeda6bfed21485630d90
Cr-Commit-Position: refs/heads/master@{#384785}
==========

[commit-bot: I haz the power, 2016-04-02 02:48:16]

Patchset 3 (id:??) landed as
https://crrev.com/1f45f77b4fa4afef5b1abeda6bfed21485630d90
Cr-Commit-Position: refs/heads/master@{#384785}