chrome/browser/usb/web_usb_permission_provider.h - Issue 1847183002: Use interface associations to check function permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/usb/web_usb_permission_provider.h

Issue 1847183002: Use interface associations to check function permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nit and fixed Windows build. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_browsertest.cc ('k') | chrome/browser/usb/web_usb_permission_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/usb/web_usb_permission_provider.h

diff --git a/chrome/browser/usb/web_usb_permission_provider.h b/chrome/browser/usb/web_usb_permission_provider.h

index e52275b256bd6d1f4419c0429843db3c78026f04..2374b11be4f2c8970b5ccae1b56daeba81e174ae 100644

--- a/chrome/browser/usb/web_usb_permission_provider.h

+++ b/chrome/browser/usb/web_usb_permission_provider.h

@@ -32,8 +32,8 @@ class WebUSBPermissionProvider : public device::usb::PermissionProvider {

bool HasConfigurationPermission(

uint8_t requested_configuration,

const device::usb::DeviceInfo& device_info) const override;

- bool HasInterfacePermission(

- uint8_t requested_interface,

+ bool HasFunctionPermission(

+ uint8_t requested_function,

uint8_t configuration_value,

const device::usb::DeviceInfo& device_info) const override;

« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_browsertest.cc ('k') | chrome/browser/usb/web_usb_permission_provider.cc » ('j') | no next file with comments »