Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/usb/web_usb_permission_provider.cc

Issue 1847183002: Use interface associations to check function permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nit and fixed Windows build. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/usb/web_usb_permission_provider.h ('k') | device/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/usb/web_usb_permission_provider.cc
diff --git a/chrome/browser/usb/web_usb_permission_provider.cc b/chrome/browser/usb/web_usb_permission_provider.cc
index c270d254a47672d92442f083232da1da846025c2..c0727eb1da6049b8832269728181063418eda0a2 100644
--- a/chrome/browser/usb/web_usb_permission_provider.cc
+++ b/chrome/browser/usb/web_usb_permission_provider.cc
@@ -27,7 +27,7 @@ namespace {
bool FindOriginInDescriptorSet(const WebUsbDescriptorSet* set,
const GURL& origin,
const uint8_t* configuration_value,
- const uint8_t* interface_number) {
+ const uint8_t* first_interface) {
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisableWebUsbSecurity))
return true;
@@ -47,9 +47,7 @@ bool FindOriginInDescriptorSet(const WebUsbDescriptorSet* set,
return true;
for (size_t j = 0; j < config->functions.size(); ++j) {
const WebUsbFunctionSubsetPtr& function = config->functions[j];
- // TODO(reillyg): Implement support for Interface Association Descriptors
- // so that this check will match associated interfaces.
- if (interface_number && *interface_number != function->first_interface)
+ if (first_interface && *first_interface != function->first_interface)
continue;
for (size_t k = 0; k < function->origins.size(); ++k)
if (origin.spec() == function->origins[k])
@@ -105,13 +103,13 @@ bool WebUSBPermissionProvider::HasConfigurationPermission(
&requested_configuration_value, nullptr);
}
-bool WebUSBPermissionProvider::HasInterfacePermission(
- uint8_t requested_interface,
+bool WebUSBPermissionProvider::HasFunctionPermission(
+ uint8_t requested_function,
uint8_t configuration_value,
const device::usb::DeviceInfo& device_info) const {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
return FindOriginInDescriptorSet(
device_info.webusb_allowed_origins.get(),
render_frame_host_->GetLastCommittedURL().GetOrigin(),
- &configuration_value, &requested_interface);
+ &configuration_value, &requested_function);
}
« no previous file with comments | « chrome/browser/usb/web_usb_permission_provider.h ('k') | device/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698