Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1846653004: Rename IGNORING_CACHE to BYPASSING_CACHE (Closed)

Created:
4 years, 8 months ago by Takashi Toyoshima
Modified:
4 years, 8 months ago
CC:
achuith+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, browser-components-watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dcheng, derat+watch_chromium.org, Dmitry Titov, dzhioev+watch_chromium.org, extensions-reviews_chromium.org, jam, jennb, jianli, loading-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, oshima+watch_chromium.org, tfarina, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename IGNORING_CACHE to BYPASSING_CACHE chrome and content uses IGNORE_CACHE to specify a strong reload. But, Blink uses ReloadBypassingCache instead of ReloadIgnoringCacheData. This is confusing and we should use consistent words in the project. This series of changes remove 'ignore' or 'ignoring' from the code base completely, and use 'validate' and 'bypass' to be consistent with net flags. BUG=599364 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation TBR=shuchen@chromium.org Committed: https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa Cr-Commit-Position: refs/heads/master@{#384581}

Patch Set 1 #

Patch Set 2 : cl format, android build fix #

Total comments: 4

Patch Set 3 : address actions.xml #

Patch Set 4 : android build fix #

Total comments: 1

Patch Set 5 : rephrase actions.xml #

Patch Set 6 : android test build fix #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -102 lines) Patch
M android_webview/browser/icon_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_command_ids.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_dll.rc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/nibs/MainMenu.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_mode/app_mode_utils.cc View 1 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/content_favicon_driver_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_command_controller_unittest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_command_handler.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/panels/panel_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/reload_button.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/favicon/content/content_favicon_driver.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_android.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_controller_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigator_impl_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/common/frame_message_enums.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/navigation_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 3 4 5 6 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846653004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846653004/20001
4 years, 8 months ago (2016-03-31 11:15:20 UTC) #9
Takashi Toyoshima
Can you review this cleanup change? Backgrounds are explained in the BUG, and two more ...
4 years, 8 months ago (2016-03-31 11:26:24 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/43020)
4 years, 8 months ago (2016-03-31 11:32:05 UTC) #12
Torne
android_webview LGTM
4 years, 8 months ago (2016-03-31 11:35:34 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-03-31 15:29:22 UTC) #14
Ilya Sherman
https://codereview.chromium.org/1846653004/diff/20001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/1846653004/diff/20001/tools/metrics/actions/actions.xml#newcode11761 tools/metrics/actions/actions.xml:11761: <description>Please enter the description of this user action.</description> Can ...
4 years, 8 months ago (2016-03-31 15:33:55 UTC) #15
palmer
rubberstamp lgtm
4 years, 8 months ago (2016-03-31 22:34:23 UTC) #16
Takashi Toyoshima
Ilya: Fixed in PS3. https://codereview.chromium.org/1846653004/diff/20001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/1846653004/diff/20001/tools/metrics/actions/actions.xml#newcode11761 tools/metrics/actions/actions.xml:11761: <description>Please enter the description of ...
4 years, 8 months ago (2016-04-01 05:53:07 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846653004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846653004/60001
4 years, 8 months ago (2016-04-01 06:01:10 UTC) #20
Takashi Toyoshima
I talked with local ChromeOS member, and he said this ChromeOS change looks safe. So, ...
4 years, 8 months ago (2016-04-01 06:02:23 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/43637) linux_android_rel_ng on ...
4 years, 8 months ago (2016-04-01 06:33:01 UTC) #23
Ilya Sherman
https://codereview.chromium.org/1846653004/diff/60001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/1846653004/diff/60001/tools/metrics/actions/actions.xml#newcode11761 tools/metrics/actions/actions.xml:11761: <description>The user triggers Super Reload operation.</description> "Super Reload" is ...
4 years, 8 months ago (2016-04-01 06:40:21 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846653004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846653004/120001
4 years, 8 months ago (2016-04-01 12:28:41 UTC) #27
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-01 14:28:16 UTC) #29
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 14:29:16 UTC) #31
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa
Cr-Commit-Position: refs/heads/master@{#384581}

Powered by Google App Engine
This is Rietveld 408576698