chrome/browser/ui/browser_command_controller.cc - Issue 1846653004: Rename IGNORING_CACHE to BYPASSING_CACHE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 1846653004: Rename IGNORING_CACHE to BYPASSING_CACHE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index 1c7bf6703231fb4ac678ac210e857570c4269b8a..c624c8cef54e83964f946316becedc81e79a776d 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -327,8 +327,8 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

case IDC_RELOAD_CLEARING_CACHE:

ClearCache(browser_);

// FALL THROUGH

- case IDC_RELOAD_IGNORING_CACHE:

- ReloadIgnoringCache(browser_, disposition);

+ case IDC_RELOAD_BYPASSING_CACHE:

+ ReloadBypassingCache(browser_, disposition);

break;

case IDC_HOME:

Home(browser_, disposition);

@@ -788,7 +788,7 @@ void BrowserCommandController::InitCommandState() {

// Navigation commands

command_updater_.UpdateCommandEnabled(IDC_RELOAD, true);

- command_updater_.UpdateCommandEnabled(IDC_RELOAD_IGNORING_CACHE, true);

+ command_updater_.UpdateCommandEnabled(IDC_RELOAD_BYPASSING_CACHE, true);

command_updater_.UpdateCommandEnabled(IDC_RELOAD_CLEARING_CACHE, true);

// Window management commands

@@ -984,7 +984,7 @@ void BrowserCommandController::UpdateCommandsForTabState() {

command_updater_.UpdateCommandEnabled(IDC_BACK, CanGoBack(browser_));

command_updater_.UpdateCommandEnabled(IDC_FORWARD, CanGoForward(browser_));

command_updater_.UpdateCommandEnabled(IDC_RELOAD, CanReload(browser_));

- command_updater_.UpdateCommandEnabled(IDC_RELOAD_IGNORING_CACHE,

+ command_updater_.UpdateCommandEnabled(IDC_RELOAD_BYPASSING_CACHE,

CanReload(browser_));

command_updater_.UpdateCommandEnabled(IDC_RELOAD_CLEARING_CACHE,

CanReload(browser_));