chrome/browser/ui/browser_command_controller_unittest.cc - Issue 1846653004: Rename IGNORING_CACHE to BYPASSING_CACHE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 1846653004: Rename IGNORING_CACHE to BYPASSING_CACHE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_command_controller_unittest.cc

diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc

index 422a346cbaea8280648413d5e081459a58439527..23746a31c27874d307d1303545d1f24f21475c98 100644

--- a/chrome/browser/ui/browser_command_controller_unittest.cc

+++ b/chrome/browser/ui/browser_command_controller_unittest.cc

@@ -51,13 +51,13 @@ TEST_F(BrowserCommandControllerTest, IsReservedCommandOrKey) {

// When there are modifier keys pressed, don't reserve.

EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(

- IDC_RELOAD_IGNORING_CACHE, content::NativeWebKeyboardEvent(ui::KeyEvent(

- ui::ET_KEY_PRESSED, ui::VKEY_F3,

- ui::DomCode::F3, ui::EF_SHIFT_DOWN))));

+ IDC_RELOAD_BYPASSING_CACHE, content::NativeWebKeyboardEvent(ui::KeyEvent(

+ ui::ET_KEY_PRESSED, ui::VKEY_F3,

+ ui::DomCode::F3, ui::EF_SHIFT_DOWN))));

EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(

- IDC_RELOAD_IGNORING_CACHE, content::NativeWebKeyboardEvent(ui::KeyEvent(

- ui::ET_KEY_PRESSED, ui::VKEY_F3,

- ui::DomCode::F3, ui::EF_CONTROL_DOWN))));

+ IDC_RELOAD_BYPASSING_CACHE, content::NativeWebKeyboardEvent(ui::KeyEvent(

+ ui::ET_KEY_PRESSED, ui::VKEY_F3,

+ ui::DomCode::F3, ui::EF_CONTROL_DOWN))));

EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(

IDC_FULLSCREEN, content::NativeWebKeyboardEvent(

ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_F4,