Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 1846103005: Reland of Include isolate.py in data for Android unit tests (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 of Include isolate.py in data for Android unit tests Now unconditionally including some directory trees to capture imports that differ based on python version (at least those that have come up so far). BUG=589318, 599692 Committed: https://crrev.com/f32bcc73dfef6e5d282c6b37fd3e25da441a0c94 Cr-Commit-Position: refs/heads/master@{#384907}

Patch Set 1 #

Patch Set 2 : added globs to catch the conditional files #

Patch Set 3 : even more cautious #

Unified diffs Side-by-side diffs Delta from patch set Stats (+717 lines, -29 lines) Patch
M PRESUBMIT.py View 1 3 chunks +105 lines, -0 lines 0 comments Download
M PRESUBMIT_test.py View 1 2 chunks +97 lines, -4 lines 0 comments Download
M PRESUBMIT_test_mocks.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/BUILD.gn View 1 1 chunk +17 lines, -22 lines 0 comments Download
A build/android/test_runner.pydeps View 1 1 chunk +152 lines, -0 lines 0 comments Download
A build/print_python_deps.py View 1 2 1 chunk +104 lines, -0 lines 0 comments Download
A build/secondary/tools/swarming_client/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A build/secondary/tools/swarming_client/isolate.pydeps View 1 2 1 chunk +224 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
agrieve
Created Reland of Include isolate.py in data for Android unit tests
4 years, 8 months ago (2016-04-01 14:56:05 UTC) #1
agrieve
On 2016/04/01 14:56:05, agrieve wrote: > Created Reland of Include isolate.py in data for Android ...
4 years, 8 months ago (2016-04-01 17:27:07 UTC) #3
agrieve
On 2016/04/01 17:27:07, agrieve wrote: > On 2016/04/01 14:56:05, agrieve wrote: > > Created Reland ...
4 years, 8 months ago (2016-04-01 17:28:10 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-03 11:17:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846103005/210001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846103005/210001
4 years, 8 months ago (2016-04-04 14:21:50 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:210001)
4 years, 8 months ago (2016-04-04 14:57:49 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 15:00:02 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f32bcc73dfef6e5d282c6b37fd3e25da441a0c94
Cr-Commit-Position: refs/heads/master@{#384907}

Powered by Google App Engine
This is Rietveld 408576698