Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1846083005: Revert of [compiler] Add relocatable pointer constants for wasm memory references. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
titzer, gdeepti1, bradnelson
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [compiler] Add relocatable pointer constants for wasm memory references. (patchset #14 id:300001 of https://codereview.chromium.org/1759383003/ ) Reason for revert: Test failures: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/8046 Original issue's description: > [compiler] Add relocatable pointer constants for wasm memory references. > > Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. > > R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org > > Committed: https://crrev.com/eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5 > Cr-Commit-Position: refs/heads/master@{#35182} TBR=bradnelson@chromium.org,titzer@chromium.org,gdeepti@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2069ab220210c9c88a381992b166da97b6211fcb Cr-Commit-Position: refs/heads/master@{#35185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -360 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/compiler/common-node-cache.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/compiler/common-node-cache.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/common-operator.h View 4 chunks +1 line, -25 lines 0 comments Download
M src/compiler/common-operator.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/instruction.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/js-graph.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +9 lines, -11 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +33 lines, -37 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/compiler/test-run-wasm-machops.cc View 1 chunk +0 lines, -145 lines 0 comments Download
M test/cctest/test-run-wasm-relocation-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Yang
Created Revert of [compiler] Add relocatable pointer constants for wasm memory references.
4 years, 8 months ago (2016-04-01 05:52:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846083005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846083005/1
4 years, 8 months ago (2016-04-01 05:52:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 05:52:57 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 05:53:29 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2069ab220210c9c88a381992b166da97b6211fcb
Cr-Commit-Position: refs/heads/master@{#35185}

Powered by Google App Engine
This is Rietveld 408576698