Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/compiler/verifier.cc

Issue 1846083005: Revert of [compiler] Add relocatable pointer constants for wasm memory references. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/compiler/wasm-compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 CheckUpperIs(node, Type::Internal()); 338 CheckUpperIs(node, Type::Internal());
339 break; 339 break;
340 case IrOpcode::kFloat32Constant: 340 case IrOpcode::kFloat32Constant:
341 case IrOpcode::kFloat64Constant: 341 case IrOpcode::kFloat64Constant:
342 case IrOpcode::kNumberConstant: 342 case IrOpcode::kNumberConstant:
343 // Constants have no inputs. 343 // Constants have no inputs.
344 CHECK_EQ(0, input_count); 344 CHECK_EQ(0, input_count);
345 // Type is a number. 345 // Type is a number.
346 CheckUpperIs(node, Type::Number()); 346 CheckUpperIs(node, Type::Number());
347 break; 347 break;
348 case IrOpcode::kRelocatableInt32Constant:
349 case IrOpcode::kRelocatableInt64Constant:
350 CHECK_EQ(0, input_count);
351 break;
352 case IrOpcode::kHeapConstant: 348 case IrOpcode::kHeapConstant:
353 // Constants have no inputs. 349 // Constants have no inputs.
354 CHECK_EQ(0, input_count); 350 CHECK_EQ(0, input_count);
355 // Type can be anything represented as a heap pointer. 351 // Type can be anything represented as a heap pointer.
356 CheckUpperIs(node, Type::TaggedPointer()); 352 CheckUpperIs(node, Type::TaggedPointer());
357 break; 353 break;
358 case IrOpcode::kExternalConstant: 354 case IrOpcode::kExternalConstant:
359 // Constants have no inputs. 355 // Constants have no inputs.
360 CHECK_EQ(0, input_count); 356 CHECK_EQ(0, input_count);
361 // Type is considered internal. 357 // Type is considered internal.
(...skipping 935 matching lines...) Expand 10 before | Expand all | Expand 10 after
1297 replacement->op()->EffectOutputCount() > 0); 1293 replacement->op()->EffectOutputCount() > 0);
1298 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1294 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1299 replacement->opcode() == IrOpcode::kFrameState); 1295 replacement->opcode() == IrOpcode::kFrameState);
1300 } 1296 }
1301 1297
1302 #endif // DEBUG 1298 #endif // DEBUG
1303 1299
1304 } // namespace compiler 1300 } // namespace compiler
1305 } // namespace internal 1301 } // namespace internal
1306 } // namespace v8 1302 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/compiler/wasm-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698