Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3527)

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js

Issue 1845473002: MD Settings: convert startup pages to use BrowserProxy/WebUIListeners (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dschuyler review Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
index bdfa547f5fba6bbcdc9d6c71c00ce013f3fb4b86..c8ba1c61264f02f3122c94ac2c8d9cff95daed12 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
@@ -26,6 +26,8 @@ var StartupPageInfo;
Polymer({
is: 'settings-startup-urls-page',
+ behaviors: [WebUIListenerBehavior],
+
properties: {
/**
* Preferences state.
@@ -35,6 +37,9 @@ Polymer({
notify: true,
},
+ /** @type {settings.StartupUrlsPageBrowserProxy} */
+ browserProxy_: Object,
+
/** @private {string} */
newUrl_: {
type: String,
@@ -48,18 +53,21 @@ Polymer({
startupPages_: Array,
},
+ created: function() {
+ this.browserProxy_ = settings.StartupUrlsPageBrowserProxyImpl.getInstance();
+ },
+
attached: function() {
- var self = this;
- cr.define('Settings', function() {
- return {
- updateStartupPages: function() {
- return self.updateStartupPages_.apply(self, arguments);
- },
- };
- });
- chrome.send('onStartupPrefsPageLoad');
+ this.addWebUIListener('update-startup-pages',
+ this.updateStartupPages_.bind(this));
+ this.browserProxy_.loadStartupPages();
},
+ /**
+ * @param {string} url Location of an image to get a set of icons fors.
+ * @return {string} A set of icon URLs.
+ * @private
+ */
getIconSet_: function(url) {
return getFaviconImageSet(url);
},
@@ -77,7 +85,7 @@ Polymer({
/** @private */
onUseCurrentPagesTap_: function() {
- chrome.send('setStartupPagesToCurrentPages');
+ this.browserProxy_.useCurrentPages();
},
/** @private */
@@ -90,13 +98,13 @@ Polymer({
* @private
*/
isAddEnabled_: function() {
- return this.newUrl_.trim().length > 0;
+ return this.browserProxy_.canAddPage(this.newUrl_);
},
/** @private */
onAddTap_: function() {
assert(this.isAddEnabled_());
- chrome.send('addStartupPage', [this.newUrl_.trim()]);
+ this.browserProxy_.addStartupPage(this.newUrl_);
this.$.addUrlDialog.close();
},
@@ -105,6 +113,6 @@ Polymer({
* @private
*/
onRemoveUrlTap_: function(e) {
- chrome.send('removeStartupPage', [e.model.index]);
+ this.browserProxy_.removeStartupPage(e.model.index);
},
});

Powered by Google App Engine
This is Rietveld 408576698