Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1845323002: Remove WebUnitTestSupport (Closed)

Created:
4 years, 8 months ago by kinuko
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, gavinp+prerender_chromium.org, jam, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, mlamouri+watch-notifications_chromium.org, Peter Beverloo, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebUnitTestSupport WebUnitTestSupport's only remaining purpose is for mocking URL requests, and the part was factored out as WebURLLoaderMockFactory and moved into blink as of https://crrev.com/1773473002 . Now we should be ready to remove WebUnitTestSupport completely! BUG=571332 Committed: https://crrev.com/2514117063f9f7c07e3dfe8beef18aebd86dba2f Cr-Commit-Position: refs/heads/master@{#385429}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : moer fix #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -278 lines) Patch
M content/child/notifications/pending_notifications_tracker_unittest.cc View 1 9 chunks +10 lines, -10 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.h View 1 3 chunks +4 lines, -19 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 2 chunks +3 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheetResourceTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResourceTest.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 1 2 3 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 1 4 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/URLTestHelpers.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp View 1 18 chunks +22 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImplTest.cpp View 1 5 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp View 1 13 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp View 1 5 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/MHTMLTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/PrerenderingTest.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TopControlsTest.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TouchActionTest.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ViewportTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebSearchableFormDataTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebSelectorTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimRequest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimTest.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebUnitTestSupport.h View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 30 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845323002/20001
4 years, 8 months ago (2016-04-05 07:34:03 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 08:54:02 UTC) #6
kinuko
PTL
4 years, 8 months ago (2016-04-05 09:04:52 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-06 04:19:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845323002/20001
4 years, 8 months ago (2016-04-06 05:18:02 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/165047)
4 years, 8 months ago (2016-04-06 05:25:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845323002/40001
4 years, 8 months ago (2016-04-06 05:43:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/206294)
4 years, 8 months ago (2016-04-06 05:57:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845323002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845323002/60001
4 years, 8 months ago (2016-04-06 06:52:10 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/14656) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-06 06:55:01 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845323002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845323002/80001
4 years, 8 months ago (2016-04-06 07:33:46 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-06 10:17:03 UTC) #28
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 10:18:14 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2514117063f9f7c07e3dfe8beef18aebd86dba2f
Cr-Commit-Position: refs/heads/master@{#385429}

Powered by Google App Engine
This is Rietveld 408576698