Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1845323002: Remove WebUnitTestSupport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 168d35e70b2aeaec607f57dd183f58f70a08ca0f..16b9f9e700d3309cc0f9efc9823376ccc4103f64 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -93,8 +93,8 @@
#include "public/platform/WebSecurityOrigin.h"
#include "public/platform/WebThread.h"
#include "public/platform/WebURL.h"
+#include "public/platform/WebURLLoaderMockFactory.h"
#include "public/platform/WebURLResponse.h"
-#include "public/platform/WebUnitTestSupport.h"
#include "public/web/WebCache.h"
#include "public/web/WebConsoleMessage.h"
#include "public/web/WebDataSource.h"
@@ -184,7 +184,8 @@ protected:
~WebFrameTest() override
{
- Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
+ Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();
+ WebCache::clear();
}
void registerMockedHttpURLLoad(const std::string& fileName)
@@ -5120,7 +5121,7 @@ TEST_P(ParameterizedWebFrameTest, ReplaceNavigationAfterHistoryNavigation)
WebHistoryItem errorHistoryItem;
errorHistoryItem.initialize();
errorHistoryItem.setURLString(WebString::fromUTF8(errorURL.c_str(), errorURL.length()));
- Platform::current()->unitTestSupport()->registerMockedErrorURL(URLTestHelpers::toKURL(errorURL), response, error);
+ Platform::current()->getURLLoaderMockFactory()->registerErrorURL(URLTestHelpers::toKURL(errorURL), response, error);
FrameTestHelpers::loadHistoryItem(frame, errorHistoryItem, WebHistoryDifferentDocumentLoad, WebURLRequest::UseProtocolCachePolicy);
WebString text = WebFrameContentDumper::dumpWebViewAsText(webViewHelper.webView(), std::numeric_limits<size_t>::max());
EXPECT_EQ("This should appear", text.utf8());
@@ -5763,12 +5764,12 @@ TEST_P(ParameterizedWebFrameTest, FirstPartyForCookiesForRedirect)
redirectResponse.setMIMEType("text/html");
redirectResponse.setHTTPStatusCode(302);
redirectResponse.setHTTPHeaderField("Location", redirect);
- Platform::current()->unitTestSupport()->registerMockedURL(testURL, redirectResponse, filePath);
+ Platform::current()->getURLLoaderMockFactory()->registerURL(testURL, redirectResponse, filePath);
WebURLResponse finalResponse;
finalResponse.initialize();
finalResponse.setMIMEType("text/html");
- Platform::current()->unitTestSupport()->registerMockedURL(redirectURL, finalResponse, filePath);
+ Platform::current()->getURLLoaderMockFactory()->registerURL(redirectURL, finalResponse, filePath);
FrameTestHelpers::WebViewHelper webViewHelper(this);
webViewHelper.initializeAndLoad(m_baseURL + "first_party_redirect.html", true);

Powered by Google App Engine
This is Rietveld 408576698