third_party/WebKit/Source/web/LinkHighlightImplTest.cpp - Issue 1845323002: Remove WebUnitTestSupport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

Issue 1845323002: Remove WebUnitTestSupport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

diff --git a/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp b/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

index 565f13258596c9eb56beab6762961890332bc1ae..f440be644fdc68b404f96720a2497136e594185a 100644

--- a/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

+++ b/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp

@@ -36,7 +36,8 @@

#include "public/platform/WebContentLayer.h"

#include "public/platform/WebFloatPoint.h"

#include "public/platform/WebSize.h"

-#include "public/platform/WebUnitTestSupport.h"

+#include "public/platform/WebURLLoaderMockFactory.h"

+#include "public/web/WebCache.h"

#include "public/web/WebFrame.h"

#include "public/web/WebFrameClient.h"

#include "public/web/WebInputEvent.h"

@@ -104,7 +105,8 @@ TEST(LinkHighlightImplTest, verifyWebViewImplIntegration)

webViewImpl->enableTapHighlightAtPoint(getTargetedEvent(webViewImpl, touchEvent));

ASSERT_EQ(0U, webViewImpl->numLinkHighlights());

- Platform::current()->unitTestSupport()->unregisterAllMockedURLs();

+ Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();

+ WebCache::clear();

}

namespace {

@@ -161,7 +163,8 @@ TEST(LinkHighlightImplTest, resetDuringNodeRemoval)

webViewImpl->updateAllLifecyclePhases();

ASSERT_EQ(0U, highlightLayer->numLinkHighlights());

- Platform::current()->unitTestSupport()->unregisterAllMockedURLs();

+ Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();

+ WebCache::clear();

}

// A lifetime test: delete LayerTreeView while running LinkHighlights.

@@ -202,7 +205,8 @@ TEST(LinkHighlightImplTest, resetLayerTreeView)

webViewImpl->willCloseLayerTreeView();

webViewHelper.reset();

- Platform::current()->unitTestSupport()->unregisterAllMockedURLs();

+ Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();

+ WebCache::clear();

}

TEST(LinkHighlightImplTest, multipleHighlights)

@@ -233,7 +237,8 @@ TEST(LinkHighlightImplTest, multipleHighlights)

webViewImpl->enableTapHighlights(highlightNodes);

EXPECT_EQ(2U, webViewImpl->numLinkHighlights());

- Platform::current()->unitTestSupport()->unregisterAllMockedURLs();

+ Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();

+ WebCache::clear();

}

} // namespace blink