Make ImageLoader non-ResourceClient

Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() depends on whether it hits MemoryCache
and whether addClient() is called before addObserver().

BUG=587663
Committed: https://crrev.com/93bf9312b6bf96719d6d2e8d66e72aa4450a9497
Cr-Commit-Position: refs/heads/master@{#386015}

[hiroshige, 2016-03-29 19:09:25]

Description was changed from

==========
Make ImageLoader non-ResourceClient

BUG=
==========

to

==========
Make ImageLoader non-ResourceClient

BUG=
==========

[hiroshige, 2016-03-29 19:09:53]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 19:10:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844603002/20001

[hiroshige, 2016-03-29 19:42:36]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 19:43:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844603002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844603002/40001

[commit-bot: I haz the power, 2016-03-29 21:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 21:10:36]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-03-30 05:01:00]

Patchset #4 (id:60001) has been deleted

[hiroshige, 2016-04-04 01:23:09]

Description was changed from

==========
Make ImageLoader non-ResourceClient

BUG=
==========

to

==========
Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() in case of successful response depends on
whether it hits MemoryCache and whether addClient() is called before
addObserver(), which might cause subtle bugs.

BUG=587663, 382170
==========

[hiroshige, 2016-04-04 01:23:09]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, yhirano@chromium.org

[hiroshige, 2016-04-04 01:28:11]

Description was changed from

==========
Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() in case of successful response depends on
whether it hits MemoryCache and whether addClient() is called before
addObserver(), which might cause subtle bugs.

BUG=587663, 382170
==========

to

==========
Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() depends on whether it hits MemoryCache
and whether addClient() is called before addObserver().

BUG=587663, 382170
==========

[hiroshige, 2016-04-04 01:28:21]

PTAL.

[hiroshige, 2016-04-04 02:09:57]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 02:10:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844603002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844603002/80001

[commit-bot: I haz the power, 2016-04-04 03:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 03:42:06]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-04-04 07:44:48]

Description was changed from

==========
Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() depends on whether it hits MemoryCache
and whether addClient() is called before addObserver().

BUG=587663, 382170
==========

to

==========
Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() depends on whether it hits MemoryCache
and whether addClient() is called before addObserver().

BUG=587663
==========

[yhirano, 2016-04-04 11:09:32]

lgtm

[hiroshige, 2016-04-05 05:59:08]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 05:59:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844603002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844603002/100001

[commit-bot: I haz the power, 2016-04-05 07:02:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 07:02:27]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-04-07 20:42:15]

lgtm

[hiroshige, 2016-04-08 05:51:41]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-04-08 05:51:41]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1844603002/#ps100001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-04-08 05:51:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844603002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844603002/100001

[commit-bot: I haz the power, 2016-04-08 07:24:50]

Description was changed from

==========
Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() depends on whether it hits MemoryCache
and whether addClient() is called before addObserver().

BUG=587663
==========

to

==========
Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() depends on whether it hits MemoryCache
and whether addClient() is called before addObserver().

BUG=587663
==========

[commit-bot: I haz the power, 2016-04-08 07:24:52]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-04-08 07:26:05]

Description was changed from

==========
Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() depends on whether it hits MemoryCache
and whether addClient() is called before addObserver().

BUG=587663
==========

to

==========
Make ImageLoader non-ResourceClient

This CL makes ImageLoader non-ResourceClient, in order to remove classes that
inherit both of ResourceClient and ImageResourceObserver.

For such a class, whether ResourceClient::notifyFinished() is called before
ImageResourceObserver::imageChanged() depends on whether it hits MemoryCache
and whether addClient() is called before addObserver().

BUG=587663

Committed: https://crrev.com/93bf9312b6bf96719d6d2e8d66e72aa4450a9497
Cr-Commit-Position: refs/heads/master@{#386015}
==========

[commit-bot: I haz the power, 2016-04-08 07:26:07]

Patchset 5 (id:??) landed as
https://crrev.com/93bf9312b6bf96719d6d2e8d66e72aa4450a9497
Cr-Commit-Position: refs/heads/master@{#386015}