third_party/WebKit/Source/core/html/HTMLImageLoader.cpp - Issue 1844603002: Make ImageLoader non-ResourceClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageLoader.cpp

Issue 1844603002: Make ImageLoader non-ResourceClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLImageLoader.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp b/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp

index 87959f8ce338fec32c15dd8468882409ee25efe1..01e59d35a5261c135f29f0445146c64e97c8177c 100644

--- a/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp

@@ -73,11 +73,11 @@ void HTMLImageLoader::noImageResourceToLoad()

loadFallbackContentForElement(element());

}

-void HTMLImageLoader::notifyFinished(Resource*)

+void HTMLImageLoader::imageNotifyFinished(ImageResource*)

{

ImageResource* cachedImage = image();

RawPtr<Element> element = this->element();

- ImageLoader::notifyFinished(cachedImage);

+ ImageLoader::imageNotifyFinished(cachedImage);

bool loadError = cachedImage->errorOccurred();

if (isHTMLImageElement(*element)) {