Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Previously, calls to ImageResourceObserver::imageNotifyFinished() were
implemented by piggybacking on ImageResourceObserver::imageChanged().
However, it causes slight differences between imageNotifyFinished() and
ResourceClient::notifyFinished(), and prevents ImageLoader from using
imageNotifyFinished() instead of notifyFinished().

This CL removes the piggybacking on imageChanged(), and implements
imageNotifyFinished() just like notifyFinished().

This CL enables ImageLoader to be non-ResourceClient in
https://codereview.chromium.org/1844603002/.

BUG=587663
Committed: https://crrev.com/9ec02ebf8f196e0e0d90e5a6686b4ca23340febb
Cr-Commit-Position: refs/heads/master@{#385968}

[hiroshige, 2016-03-29 19:07:03]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 19:07:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843533005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843533005/1

[hiroshige, 2016-03-29 19:09:37]

Description was changed from

==========
Call imageNotifyFinished() just before ResourceClient::notifyFinished()

BUG=
==========

to

==========
Call imageNotifyFinished() just before ResourceClient::notifyFinished()

BUG=
==========

[hiroshige, 2016-03-29 19:42:11]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 19:42:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843533005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843533005/20001

[commit-bot: I haz the power, 2016-03-29 20:56:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 20:56:45]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-03-30 05:01:09]

Patchset #3 (id:40001) has been deleted

[hiroshige, 2016-04-04 01:12:22]

Description was changed from

==========
Call imageNotifyFinished() just before ResourceClient::notifyFinished()

BUG=
==========

to

==========
Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Previously, calls to ImageResourceObserver::imageNotifyFinished() were
implemented by piggybacking on ImageResourceObserver::imageChanged().
However, it causes slight differences between imageNotifyFinished() and
ResourceClient::notifyFinished(), and prevents ImageLoader from using
imageNotifyFinished() instead of notifyFinished().

This CL removes the piggybacking on imageChanged(), and implements
imageNotifyFinished() just like notifyFinished().

This CL enables ImageLoader to be non-ResourceClient in
https://codereview.chromium.org/1844603002/.

BUG=587663
==========

[hiroshige, 2016-04-04 01:12:23]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, yhirano@chromium.org

[hiroshige, 2016-04-04 01:26:12]

PTAL.

[hiroshige, 2016-04-04 02:03:16]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 02:03:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843533005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843533005/60001

[commit-bot: I haz the power, 2016-04-04 03:39:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 03:39:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yhirano, 2016-04-04 11:07:30]

lgtm

https://codereview.chromium.org/1843533005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ImageResource.cpp (right):

https://codereview.chromium.org/1843533005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ImageResource.cpp:148:
didAddObserver(observer);
[optional] I'm not sure if it's a good idea to have didAddObserver separately.
For me, inlining it makes the code easier to read in this case.

[hiroshige, 2016-04-05 05:57:20]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 05:57:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843533005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843533005/80001

[hiroshige, 2016-04-05 06:00:51]

https://codereview.chromium.org/1843533005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ImageResource.cpp (right):

https://codereview.chromium.org/1843533005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ImageResource.cpp:148:
didAddObserver(observer);
On 2016/04/04 11:07:30, yhirano wrote:
> [optional] I'm not sure if it's a good idea to have didAddObserver separately.
> For me, inlining it makes the code easier to read in this case.

Done.

[commit-bot: I haz the power, 2016-04-05 07:02:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 07:02:25]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-04-07 20:41:47]

lgtm

[hiroshige, 2016-04-08 00:29:46]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-04-08 00:29:46]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/1843533005/#ps80001
(title: "Rebase, Reflect yhirano's comment")

[commit-bot: I haz the power, 2016-04-08 00:30:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843533005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843533005/80001

[commit-bot: I haz the power, 2016-04-08 03:11:11]

Description was changed from

==========
Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Previously, calls to ImageResourceObserver::imageNotifyFinished() were
implemented by piggybacking on ImageResourceObserver::imageChanged().
However, it causes slight differences between imageNotifyFinished() and
ResourceClient::notifyFinished(), and prevents ImageLoader from using
imageNotifyFinished() instead of notifyFinished().

This CL removes the piggybacking on imageChanged(), and implements
imageNotifyFinished() just like notifyFinished().

This CL enables ImageLoader to be non-ResourceClient in
https://codereview.chromium.org/1844603002/.

BUG=587663
==========

to

==========
Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Previously, calls to ImageResourceObserver::imageNotifyFinished() were
implemented by piggybacking on ImageResourceObserver::imageChanged().
However, it causes slight differences between imageNotifyFinished() and
ResourceClient::notifyFinished(), and prevents ImageLoader from using
imageNotifyFinished() instead of notifyFinished().

This CL removes the piggybacking on imageChanged(), and implements
imageNotifyFinished() just like notifyFinished().

This CL enables ImageLoader to be non-ResourceClient in
https://codereview.chromium.org/1844603002/.

BUG=587663
==========

[commit-bot: I haz the power, 2016-04-08 03:11:12]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-04-08 03:12:05]

Description was changed from

==========
Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Previously, calls to ImageResourceObserver::imageNotifyFinished() were
implemented by piggybacking on ImageResourceObserver::imageChanged().
However, it causes slight differences between imageNotifyFinished() and
ResourceClient::notifyFinished(), and prevents ImageLoader from using
imageNotifyFinished() instead of notifyFinished().

This CL removes the piggybacking on imageChanged(), and implements
imageNotifyFinished() just like notifyFinished().

This CL enables ImageLoader to be non-ResourceClient in
https://codereview.chromium.org/1844603002/.

BUG=587663
==========

to

==========
Call imageNotifyFinished() just before ResourceClient::notifyFinished()

Previously, calls to ImageResourceObserver::imageNotifyFinished() were
implemented by piggybacking on ImageResourceObserver::imageChanged().
However, it causes slight differences between imageNotifyFinished() and
ResourceClient::notifyFinished(), and prevents ImageLoader from using
imageNotifyFinished() instead of notifyFinished().

This CL removes the piggybacking on imageChanged(), and implements
imageNotifyFinished() just like notifyFinished().

This CL enables ImageLoader to be non-ResourceClient in
https://codereview.chromium.org/1844603002/.

BUG=587663

Committed: https://crrev.com/9ec02ebf8f196e0e0d90e5a6686b4ca23340febb
Cr-Commit-Position: refs/heads/master@{#385968}
==========

[commit-bot: I haz the power, 2016-04-08 03:12:07]

Patchset 4 (id:??) landed as
https://crrev.com/9ec02ebf8f196e0e0d90e5a6686b4ca23340febb
Cr-Commit-Position: refs/heads/master@{#385968}