third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

index 101706dae4ca904599a4401981610a99f9d16b37..84d20e4fe7e16b66b059ba42f07d2950e7efea47 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

@@ -69,7 +69,7 @@ PassRefPtr<EncodedFormData> PasswordCredential::encodeFormData(String& contentTy

params->append(idName(), id());

params->append(passwordName(), password());

- contentType = AtomicString("application/x-www-form-urlencoded;charset=UTF-8", AtomicString::ConstructFromLiteral);

+ contentType = AtomicString("application/x-www-form-urlencoded;charset=UTF-8");

return params->encodeFormData();

}

@@ -93,7 +93,7 @@ PassRefPtr<EncodedFormData> PasswordCredential::encodeFormData(String& contentTy

formData->append(passwordName(), password());

RefPtr<EncodedFormData> encodedData = formData->encodeMultiPartFormData();

- contentType = AtomicString("multipart/form-data; boundary=", AtomicString::ConstructFromLiteral) + encodedData->boundary().data();

+ contentType = AtomicString("multipart/form-data; boundary=") + encodedData->boundary().data();

return encodedData.release();

}