third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchRequestData.h » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp

index ca7f791d2909376e951a18e6e62d26e01a5299f9..4d237a3d688edd3e0a5f74e201d640980645d89c 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp

@@ -265,7 +265,7 @@ private:

}

// Here we handle body->boundary() as a C-style string. See

// FormDataEncoder::generateUniqueBoundaryString.

- blobData->setContentType(AtomicString("multipart/form-data; boundary=", AtomicString::ConstructFromLiteral) + body->boundary().data());

+ blobData->setContentType(AtomicString("multipart/form-data; boundary=") + body->boundary().data());

auto size = blobData->length();

if (factory) {

// For testing