Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/credentialmanager/PasswordCredential.h" 5 #include "modules/credentialmanager/PasswordCredential.h"
6 6
7 #include "bindings/core/v8/Dictionary.h" 7 #include "bindings/core/v8/Dictionary.h"
8 #include "bindings/core/v8/ExceptionState.h" 8 #include "bindings/core/v8/ExceptionState.h"
9 #include "core/dom/ExecutionContext.h" 9 #include "core/dom/ExecutionContext.h"
10 #include "core/dom/URLSearchParams.h" 10 #include "core/dom/URLSearchParams.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 URLSearchParams* params = URLSearchParams::create(URLSearchParamsInit()) ; 62 URLSearchParams* params = URLSearchParams::create(URLSearchParamsInit()) ;
63 URLSearchParams* additionalData = m_additionalData.getAsURLSearchParams( ); 63 URLSearchParams* additionalData = m_additionalData.getAsURLSearchParams( );
64 for (const auto& param : additionalData->params()) { 64 for (const auto& param : additionalData->params()) {
65 const String& name = param.first; 65 const String& name = param.first;
66 if (name != idName() && name != passwordName()) 66 if (name != idName() && name != passwordName())
67 params->append(name, param.second); 67 params->append(name, param.second);
68 } 68 }
69 params->append(idName(), id()); 69 params->append(idName(), id());
70 params->append(passwordName(), password()); 70 params->append(passwordName(), password());
71 71
72 contentType = AtomicString("application/x-www-form-urlencoded;charset=UT F-8", AtomicString::ConstructFromLiteral); 72 contentType = AtomicString("application/x-www-form-urlencoded;charset=UT F-8");
73 73
74 return params->encodeFormData(); 74 return params->encodeFormData();
75 } 75 }
76 76
77 // Otherwise, we'll build a multipart response. 77 // Otherwise, we'll build a multipart response.
78 FormData* formData = FormData::create(nullptr); 78 FormData* formData = FormData::create(nullptr);
79 if (m_additionalData.isFormData()) { 79 if (m_additionalData.isFormData()) {
80 FormData* additionalData = m_additionalData.getAsFormData(); 80 FormData* additionalData = m_additionalData.getAsFormData();
81 for (const FormData::Entry* entry : additionalData->entries()) { 81 for (const FormData::Entry* entry : additionalData->entries()) {
82 const String& name = formData->decode(entry->name()); 82 const String& name = formData->decode(entry->name());
83 if (name == idName() || name == passwordName()) 83 if (name == idName() || name == passwordName())
84 continue; 84 continue;
85 85
86 if (entry->blob()) 86 if (entry->blob())
87 formData->append(name, entry->blob(), entry->filename()); 87 formData->append(name, entry->blob(), entry->filename());
88 else 88 else
89 formData->append(name, formData->decode(entry->value())); 89 formData->append(name, formData->decode(entry->value()));
90 } 90 }
91 } 91 }
92 formData->append(idName(), id()); 92 formData->append(idName(), id());
93 formData->append(passwordName(), password()); 93 formData->append(passwordName(), password());
94 94
95 RefPtr<EncodedFormData> encodedData = formData->encodeMultiPartFormData(); 95 RefPtr<EncodedFormData> encodedData = formData->encodeMultiPartFormData();
96 contentType = AtomicString("multipart/form-data; boundary=", AtomicString::C onstructFromLiteral) + encodedData->boundary().data(); 96 contentType = AtomicString("multipart/form-data; boundary=") + encodedData-> boundary().data();
97 return encodedData.release(); 97 return encodedData.release();
98 } 98 }
99 99
100 const String& PasswordCredential::password() const 100 const String& PasswordCredential::password() const
101 { 101 {
102 return static_cast<PlatformPasswordCredential*>(m_platformCredential.get())- >password(); 102 return static_cast<PlatformPasswordCredential*>(m_platformCredential.get())- >password();
103 } 103 }
104 104
105 DEFINE_TRACE(PasswordCredential) 105 DEFINE_TRACE(PasswordCredential)
106 { 106 {
107 Credential::trace(visitor); 107 Credential::trace(visitor);
108 visitor->trace(m_additionalData); 108 visitor->trace(m_additionalData);
109 } 109 }
110 110
111 } // namespace blink 111 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698