third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp ('k') | third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

index c578a5df330b05e0fa71e1414b05fb9341db4e82..e13e43e039cdf88f7dcc38261e6b595e46ce770d 100644

--- a/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

@@ -215,7 +215,7 @@ bool VTTParser::hasRequiredFileIdentifier(const String& line)

void VTTParser::collectMetadataHeader(const String& line)

{

// WebVTT header parsing (WebVTT parser algorithm step 12)

- DEFINE_STATIC_LOCAL(const AtomicString, regionHeaderName, ("Region", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, regionHeaderName, ("Region"));

// The only currently supported header is the "Region" header.

if (!RuntimeEnabledFeatures::webVTTRegionsEnabled())