Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 return false; 208 return false;
209 if (line.length() > fileIdentifierLength && !isASpace(line[fileIdentifierLen gth])) 209 if (line.length() > fileIdentifierLength && !isASpace(line[fileIdentifierLen gth]))
210 return false; 210 return false;
211 211
212 return true; 212 return true;
213 } 213 }
214 214
215 void VTTParser::collectMetadataHeader(const String& line) 215 void VTTParser::collectMetadataHeader(const String& line)
216 { 216 {
217 // WebVTT header parsing (WebVTT parser algorithm step 12) 217 // WebVTT header parsing (WebVTT parser algorithm step 12)
218 DEFINE_STATIC_LOCAL(const AtomicString, regionHeaderName, ("Region", AtomicS tring::ConstructFromLiteral)); 218 DEFINE_STATIC_LOCAL(const AtomicString, regionHeaderName, ("Region"));
219 219
220 // The only currently supported header is the "Region" header. 220 // The only currently supported header is the "Region" header.
221 if (!RuntimeEnabledFeatures::webVTTRegionsEnabled()) 221 if (!RuntimeEnabledFeatures::webVTTRegionsEnabled())
222 return; 222 return;
223 223
224 // Step 12.4 If line contains the character ":" (A U+003A COLON), then set m etadata's 224 // Step 12.4 If line contains the character ":" (A U+003A COLON), then set m etadata's
225 // name to the substring of line before the first ":" character and 225 // name to the substring of line before the first ":" character and
226 // metadata's value to the substring after this character. 226 // metadata's value to the substring after this character.
227 size_t colonPosition = line.find(':'); 227 size_t colonPosition = line.find(':');
228 if (colonPosition == kNotFound) 228 if (colonPosition == kNotFound)
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 } 559 }
560 560
561 DEFINE_TRACE(VTTParser) 561 DEFINE_TRACE(VTTParser)
562 { 562 {
563 visitor->trace(m_document); 563 visitor->trace(m_document);
564 visitor->trace(m_cueList); 564 visitor->trace(m_cueList);
565 visitor->trace(m_regionList); 565 visitor->trace(m_regionList);
566 } 566 }
567 567
568 } // namespace blink 568 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698