Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
index 71f26d9c2ccbe4dae7f4a3839d18fb2e93415e94..f92aa41e89d4ca3153fc1376b9a85dafe99ae5d9 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
@@ -156,7 +156,7 @@ void VTTRegion::setViewportAnchorY(double value, ExceptionState& exceptionState)
const AtomicString VTTRegion::scroll() const
{
- DEFINE_STATIC_LOCAL(const AtomicString, upScrollValueKeyword, ("up", AtomicString::ConstructFromLiteral));
+ DEFINE_STATIC_LOCAL(const AtomicString, upScrollValueKeyword, ("up"));
if (m_scroll)
return upScrollValueKeyword;
@@ -166,7 +166,7 @@ const AtomicString VTTRegion::scroll() const
void VTTRegion::setScroll(const AtomicString& value, ExceptionState& exceptionState)
{
- DEFINE_STATIC_LOCAL(const AtomicString, upScrollValueKeyword, ("up", AtomicString::ConstructFromLiteral));
+ DEFINE_STATIC_LOCAL(const AtomicString, upScrollValueKeyword, ("up"));
if (value != emptyString() && value != upScrollValueKeyword) {
exceptionState.throwDOMException(SyntaxError, "The value provided ('" + value + "') is invalid. The 'scroll' property must be either the empty string, or 'up'.");
@@ -238,7 +238,7 @@ static inline bool parsedEntireRun(const VTTScanner& input, const VTTScanner::Ru
void VTTRegion::parseSettingValue(RegionSetting setting, VTTScanner& input)
{
- DEFINE_STATIC_LOCAL(const AtomicString, scrollUpValueKeyword, ("up", AtomicString::ConstructFromLiteral));
+ DEFINE_STATIC_LOCAL(const AtomicString, scrollUpValueKeyword, ("up"));
VTTScanner::Run valueRun = input.collectUntil<VTTParser::isASpace>();
@@ -297,7 +297,7 @@ void VTTRegion::parseSettingValue(RegionSetting setting, VTTScanner& input)
const AtomicString& VTTRegion::textTrackCueContainerShadowPseudoId()
{
DEFINE_STATIC_LOCAL(const AtomicString, trackRegionCueContainerPseudoId,
- ("-webkit-media-text-track-region-container", AtomicString::ConstructFromLiteral));
+ ("-webkit-media-text-track-region-container"));
return trackRegionCueContainerPseudoId;
}
@@ -305,7 +305,7 @@ const AtomicString& VTTRegion::textTrackCueContainerShadowPseudoId()
const AtomicString& VTTRegion::textTrackCueContainerScrollingClass()
{
DEFINE_STATIC_LOCAL(const AtomicString, trackRegionCueContainerScrollingClass,
- ("scrolling", AtomicString::ConstructFromLiteral));
+ ("scrolling"));
return trackRegionCueContainerScrollingClass;
}
@@ -313,7 +313,7 @@ const AtomicString& VTTRegion::textTrackCueContainerScrollingClass()
const AtomicString& VTTRegion::textTrackRegionShadowPseudoId()
{
DEFINE_STATIC_LOCAL(const AtomicString, trackRegionShadowPseudoId,
- ("-webkit-media-text-track-region", AtomicString::ConstructFromLiteral));
+ ("-webkit-media-text-track-region"));
return trackRegionShadowPseudoId;
}

Powered by Google App Engine
This is Rietveld 408576698