CREDENTIAL: Rework the integration with Fetch (1/2)

third_party/WebKit/Source/modules/fetch/FetchRequestData.h

Index: third_party/WebKit/Source/modules/fetch/FetchRequestData.h
diff --git a/third_party/WebKit/Source/modules/fetch/FetchRequestData.h b/third_party/WebKit/Source/modules/fetch/FetchRequestData.h
index ebd39b7348ecf1550421e77cde696286764fec7d..8a29dbf3a0d9fa7c2933415567ef361870db0a18 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchRequestData.h
+++ b/third_party/WebKit/Source/modules/fetch/FetchRequestData.h
@@ -21,6 +21,7 @@ namespace blink {
 class BodyStreamBuffer;
 class ExecutionContext;
 class FetchHeaderList;
+class PasswordCredential;
 class SecurityOrigin;
 class WebServiceWorkerRequest;
 
@@ -71,6 +72,8 @@ public:
     void setMIMEType(const String& type) { m_mimeType = type; }
     String integrity() const { return m_integrity; }
     void setIntegrity(const String& integrity) { m_integrity = integrity; }
+    BodyStreamBuffer* attachedCredentialBuffer() const { return m_attachedCredentialBuffer; }
+    void setAttachedCredentialBuffer(BodyStreamBuffer* buffer) { m_attachedCredentialBuffer = buffer; }
 
     // We use these strings instead of "no-referrer" and "client" in the spec.
     static AtomicString noReferrerString() { return AtomicString(); }
@@ -107,6 +110,7 @@ private:
     Member<BodyStreamBuffer> m_buffer;
     String m_mimeType;
     String m_integrity;
+    Member<BodyStreamBuffer> m_attachedCredentialBuffer;

[horo, 2016/04/05 07:24:35]

BodyStreamBuffer is designed to be readable only once.
For example this code throws an error.

var r1 = new Request("./resources/echo-post.php", {method: 'POST', body:
'hello'});
var r2 = new Request(r1);
fetch(r1)  // This throws TypeError.

What is the expected behavior of this code?

var c = new PasswordCredential({id: 'id', password: 'pass'});
var r1 = new Request("./resources/echo-post.php", { credentials: c, method:
"POST" });
var r2 = new Request(r1);
fetch(r1)  // Does this fetch contains the credentials?

If fetch(r1) must contain the credentials, you should not use BodyStreamBuffer
for credentials.
You can have the credentials as a EncodedFormData.


If you want to use a BodyStreamBuffer for the credentials in FetchRequestData,
you have to treat it same as the body.

From FetchRequestData::cloneExceptBody() remove:
In FetchRequestData::clone():
In FetchRequestData::pass():
In Request::createRequestWithRequestOrString():

 };
 
 } // namespace blink