third_party/WebKit/Source/modules/fetch/FetchManager.cpp - Issue 1844053003: CREDENTIAL: Rework the integration with Fetch (1/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 1844053003: CREDENTIAL: Rework the integration with Fetch (1/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch.html ('K') | « third_party/WebKit/Source/modules/fetch/Body.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchRequestData.h » ('j') | third_party/WebKit/Source/modules/fetch/FetchRequestData.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

index f640ee643b894c327255cb8722c9b1f7c161c6b7..8917759fd8725aee44c7830842bc1eccf2ff18e7 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

@@ -565,9 +565,10 @@ void FetchManager::Loader::performHTTPFetch(bool corsFlag, bool corsPreflightFla

}

if (m_request->method() != HTTPNames::GET && m_request->method() != HTTPNames::HEAD) {

- if (m_request->buffer()) {

+ if (m_request->buffer())

request.setHTTPBody(m_request->buffer()->drainAsFormData());

- }

+ if (m_request->attachedCredentialBuffer())

+ request.setAttachedCredentialBody(m_request->attachedCredentialBuffer()->drainAsFormData());

}

request.setFetchRedirectMode(m_request->redirect());

request.setUseStreamOnResponse(true);