CREDENTIAL: Rework the integration with Fetch (1/2)

third_party/WebKit/Source/modules/fetch/FetchRequestData.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef FetchRequestData_h
 #define FetchRequestData_h
 
 #include "platform/heap/Handle.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/Referrer.h"
 #include "platform/weborigin/ReferrerPolicy.h"
 #include "public/platform/WebURLRequest.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerRequest.h"
 #include "wtf/PassOwnPtr.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/text/AtomicString.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 class BodyStreamBuffer;
 class ExecutionContext;
 class FetchHeaderList;
+class PasswordCredential;
 class SecurityOrigin;
 class WebServiceWorkerRequest;
 
 class FetchRequestData final : public GarbageCollectedFinalized<FetchRequestData> {
     WTF_MAKE_NONCOPYABLE(FetchRequestData);
 public:
     enum Tainting { BasicTainting, CORSTainting, OpaqueTainting };
 
     static FetchRequestData* create();
     static FetchRequestData* create(ExecutionContext*, const WebServiceWorkerRequest&);
@@ skipping 30 matching lines @@
     Tainting responseTainting() const { return m_responseTainting; }
     FetchHeaderList* headerList() const { return m_headerList.get(); }
     void setHeaderList(FetchHeaderList* headerList) { m_headerList = headerList; }
     BodyStreamBuffer* buffer() const { return m_buffer; }
     // Call Request::refreshBody() after calling setBuffer().
     void setBuffer(BodyStreamBuffer* buffer) { m_buffer = buffer; }
     String mimeType() const { return m_mimeType; }
     void setMIMEType(const String& type) { m_mimeType = type; }
     String integrity() const { return m_integrity; }
     void setIntegrity(const String& integrity) { m_integrity = integrity; }
+    BodyStreamBuffer* attachedCredentialBuffer() const { return m_attachedCredentialBuffer; }
+    void setAttachedCredentialBuffer(BodyStreamBuffer* buffer) { m_attachedCredentialBuffer = buffer; }
 
     // We use these strings instead of "no-referrer" and "client" in the spec.
     static AtomicString noReferrerString() { return AtomicString(); }
     static AtomicString clientReferrerString() { return AtomicString("about:client"); }
 
     DECLARE_TRACE();
 
 private:
     FetchRequestData();
 
@@ skipping 16 matching lines @@
     // FIXME: Support m_synchronousFlag;
     WebURLRequest::FetchRequestMode m_mode;
     WebURLRequest::FetchCredentialsMode m_credentials;
     WebURLRequest::FetchRedirectMode m_redirect;
     // FIXME: Support m_useURLCredentialsFlag;
     // FIXME: Support m_redirectCount;
     Tainting m_responseTainting;
     Member<BodyStreamBuffer> m_buffer;
     String m_mimeType;
     String m_integrity;
+    Member<BodyStreamBuffer> m_attachedCredentialBuffer;

[horo, 2016/04/05 07:24:35]

BodyStreamBuffer is designed to be readable only once.
For example this code throws an error.

var r1 = new Request("./resources/echo-post.php", {method: 'POST', body:
'hello'});
var r2 = new Request(r1);
fetch(r1)  // This throws TypeError.

What is the expected behavior of this code?

var c = new PasswordCredential({id: 'id', password: 'pass'});
var r1 = new Request("./resources/echo-post.php", { credentials: c, method:
"POST" });
var r2 = new Request(r1);
fetch(r1)  // Does this fetch contains the credentials?

If fetch(r1) must contain the credentials, you should not use BodyStreamBuffer
for credentials.
You can have the credentials as a EncodedFormData.


If you want to use a BodyStreamBuffer for the credentials in FetchRequestData,
you have to treat it same as the body.

From FetchRequestData::cloneExceptBody() remove:
In FetchRequestData::clone():
In FetchRequestData::pass():
In Request::createRequestWithRequestOrString():

 };
 
 } // namespace blink
 
 #endif // FetchRequestData_h