third_party/WebKit/Source/core/frame/VisualViewport.cpp - Issue 1844013002: Fix main thread top controls scrolling to mirror CC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.cpp

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta

Patch Set: Let ResizeWebWidget decide whether to resize Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_widget.cc ('K') | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/web/ResizeViewportAnchor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/VisualViewport.cpp

diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.cpp b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

index 972c3bd1f4798080d8e9668818e0a3fc4dbaf597..e522078ebc506c952ff4fa969c996c5203248392 100644

--- a/third_party/WebKit/Source/core/frame/VisualViewport.cpp

+++ b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

@@ -545,7 +545,7 @@ DoublePoint VisualViewport::maximumScrollPositionDouble() const

if (!mainFrame())

return IntPoint();

- // FIXME: We probably shouldn't be storing the bounds in a float. crbug.com/422331.

+ // TODO(bokan): We probably shouldn't be storing the bounds in a float. crbug.com/470718.

FloatSize frameViewSize(contentsSize());

if (m_topControlsAdjustment) {

@@ -557,7 +557,7 @@ DoublePoint VisualViewport::maximumScrollPositionDouble() const

frameViewSize = FloatSize(flooredIntSize(frameViewSize));

FloatSize viewportSize(m_size);

- viewportSize.expand(0, m_topControlsAdjustment);

+ viewportSize.expand(0, ceilf(m_topControlsAdjustment));

FloatSize maxPosition = frameViewSize - viewportSize;

maxPosition.scale(1 / m_scale);