third_party/WebKit/Source/core/frame/FrameView.h - Issue 1844013002: Fix main thread top controls scrolling to mirror CC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta

Patch Set: Let ResizeWebWidget decide whether to resize Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/FrameView.h

diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h

index 30ff045699f08d3c1a52f83cbb857c0088533edc..8a9014f6672105b1ace542b591a5a312279cc6f4 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.h

+++ b/third_party/WebKit/Source/core/frame/FrameView.h

@@ -356,7 +356,7 @@ public:

// commit scroll offsets before a WebView::resize occurs, we need to adjust

// our scroll extents to prevent clamping the scroll offsets.

void setTopControlsViewportAdjustment(float);

- IntSize topControlsSize() const { return IntSize(0, roundf(m_topControlsViewportAdjustment)); }

+ IntSize topControlsSize() const { return IntSize(0, ceilf(m_topControlsViewportAdjustment)); }

IntPoint maximumScrollPosition() const override;

« content/renderer/render_widget.cc ('K') | « content/renderer/render_widget.cc ('k') | third_party/WebKit/Source/core/frame/VisualViewport.cpp » ('j') | no next file with comments »