Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1843553002: Remove DCHECK(!url.has_ref()); in ServiceWorkerUtils::ScopeMatches() (Closed)

Created:
4 years, 8 months ago by horo
Modified:
4 years, 8 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK(!url.has_ref()); in ServiceWorkerUtils::ScopeMatches() |url| may have ref when it is called from devtools::service_worker::ServiceWorkerHandler. BUG=598410 Committed: https://crrev.com/2ad8fb5ec36737523c4e878a6adf59dc2a130994 Cr-Commit-Position: refs/heads/master@{#383678}

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/common/service_worker/service_worker_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/service_worker/service_worker_utils_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
horo
falken@ Could you please review this?
4 years, 8 months ago (2016-03-29 05:19:49 UTC) #3
falken
lgtm
4 years, 8 months ago (2016-03-29 05:39:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843553002/20001
4 years, 8 months ago (2016-03-29 05:43:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 06:15:26 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 06:17:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ad8fb5ec36737523c4e878a6adf59dc2a130994
Cr-Commit-Position: refs/heads/master@{#383678}

Powered by Google App Engine
This is Rietveld 408576698