content/common/service_worker/service_worker_utils_unittest.cc - Issue 1843553002: Remove DCHECK(!url.has_ref()); in ServiceWorkerUtils::ScopeMatches()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_utils_unittest.cc

Issue 1843553002: Remove DCHECK(!url.has_ref()); in ServiceWorkerUtils::ScopeMatches() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/service_worker/service_worker_utils_unittest.cc

diff --git a/content/common/service_worker/service_worker_utils_unittest.cc b/content/common/service_worker/service_worker_utils_unittest.cc

index f8ab571682dc28df417d44ccb42926f24627b428..393c36ce158846919e5ad822c7ed2e37d65f50f6 100644

--- a/content/common/service_worker/service_worker_utils_unittest.cc

+++ b/content/common/service_worker/service_worker_utils_unittest.cc

@@ -38,6 +38,8 @@ TEST(ServiceWorkerUtilsTest, ScopeMatches) {

ASSERT_FALSE(ServiceWorkerUtils::ScopeMatches(

GURL("http://www.example.com/"),

GURL("https://www.example.com/page.html")));

+ ASSERT_TRUE(ServiceWorkerUtils::ScopeMatches(

+ GURL("http://www.example.com/"), GURL("http://www.example.com/#a")));

ASSERT_FALSE(ServiceWorkerUtils::ScopeMatches(GURL("http://www.example.com/"),

GURL("http://www.foo.com/")));

« no previous file with comments | « content/common/service_worker/service_worker_utils.cc ('k') | no next file » | no next file with comments »