content/common/service_worker/service_worker_utils.cc - Issue 1843553002: Remove DCHECK(!url.has_ref()); in ServiceWorkerUtils::ScopeMatches()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_utils.cc

Issue 1843553002: Remove DCHECK(!url.has_ref()); in ServiceWorkerUtils::ScopeMatches() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/service_worker/service_worker_utils.cc

diff --git a/content/common/service_worker/service_worker_utils.cc b/content/common/service_worker/service_worker_utils.cc

index 31f1f305f268fd4cd8243d8741a5212d61e5c749..3a4971fc4ec7cd75a1cd022eba2e40853a891811 100644

--- a/content/common/service_worker/service_worker_utils.cc

+++ b/content/common/service_worker/service_worker_utils.cc

@@ -41,7 +41,6 @@ bool AllOriginsMatch(const GURL& url_a, const GURL& url_b, const GURL& url_c) {

// static

bool ServiceWorkerUtils::ScopeMatches(const GURL& scope, const GURL& url) {

DCHECK(!scope.has_ref());

- DCHECK(!url.has_ref());

return base::StartsWith(url.spec(), scope.spec(),

base::CompareCase::SENSITIVE);

}

« no previous file with comments | « no previous file | content/common/service_worker/service_worker_utils_unittest.cc » ('j') | no next file with comments »