Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1843163003: [Extensions] Convert APIs to use movable types [14] (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert APIs to use movable types [14] Generated extensions code used to rely on linked_ptrs for non-copyable types in containers. Now, we can make these types movable. Update the following APIs to use movable types in this CL: - experience_sampling_private.json - windows.json - test.json - usb.idl - virtual_keyboard_private.json - vpn_provider.idl - web_request.json - web_request_internal.json - web_view_internal.json - webcam_private.idl BUG=595949 Committed: https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d Cr-Commit-Position: refs/heads/master@{#384126}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -96 lines) Patch
M chrome/browser/extensions/api/sessions/sessions_api.h View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 7 chunks +22 lines, -26 lines 0 comments Download
M chrome/common/extensions/api/experience_sampling_private.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/windows.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/guest_view/web_view/web_view_internal_api.cc View 3 chunks +4 lines, -5 lines 1 comment Download
M extensions/browser/api/usb/usb_api.cc View 6 chunks +44 lines, -50 lines 0 comments Download
M extensions/common/api/test.json View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/usb.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/virtual_keyboard_private.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/vpn_provider.idl View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/web_request.json View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/web_request_internal.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/web_view_internal.json View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/api/webcam_private.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
so close!
4 years, 8 months ago (2016-03-30 21:04:06 UTC) #2
lazyboy
lgtm https://codereview.chromium.org/1843163003/diff/1/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc File extensions/browser/api/guest_view/web_view/web_view_internal_api.cc (left): https://codereview.chromium.org/1843163003/diff/1/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc#oldcode212 extensions/browser/api/guest_view/web_view/web_view_internal_api.cc:212: std::vector<linked_ptr<ContentScriptDetails>> content_script_list, Nice fix!
4 years, 8 months ago (2016-03-30 21:28:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843163003/1
4 years, 8 months ago (2016-03-30 22:23:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 22:46:26 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 22:51:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/372cf1d54c86e42644b7ef4a6269ee11f4ec278d
Cr-Commit-Position: refs/heads/master@{#384126}

Powered by Google App Engine
This is Rietveld 408576698