[Extensions] Convert APIs to use movable types [14]

extensions/browser/api/guest_view/web_view/web_view_internal_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/guest_view/web_view/web_view_internal_api.h"
 
 #include <utility>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
@@ skipping 191 matching lines @@
   // exclude_globs:
   if (script_value.exclude_globs) {
     for (const std::string& glob : *script_value.exclude_globs)
       script->add_exclude_glob(glob);
   }
 
   return true;
 }
 
 bool ParseContentScripts(
-    std::vector<linked_ptr<ContentScriptDetails>> content_script_list,

[lazyboy, 2016/03/30 21:28:33]

Nice fix!

+    const std::vector<ContentScriptDetails>& content_script_list,
     const extensions::Extension* extension,
     const HostID& host_id,
     bool incognito_enabled,
     const GURL& owner_base_url,
     std::set<UserScript>* result,
     std::string* error) {
   if (content_script_list.empty())
     return false;
 
   std::set<std::string> names;
-  for (const linked_ptr<ContentScriptDetails> script_value :
-       content_script_list) {
-    const std::string& name = script_value->name;
+  for (const ContentScriptDetails& script_value : content_script_list) {
+    const std::string& name = script_value.name;
     if (!names.insert(name).second) {
       // The name was already in the list.
       *error = kDuplicatedContentScriptNamesError;
       return false;
     }
 
     UserScript script;
-    if (!ParseContentScript(*script_value, extension, owner_base_url, &script,
+    if (!ParseContentScript(script_value, extension, owner_base_url, &script,
                             error))
       return false;
 
     script.set_id(UserScript::GenerateUserScriptID());
     script.set_name(name);
     script.set_incognito_enabled(incognito_enabled);
     script.set_host_id(host_id);
     script.set_consumer_instance_type(UserScript::WEBVIEW);
     result->insert(script);
   }
@@ skipping 708 matching lines @@
   // Will finish asynchronously.
   return true;
 }
 
 void WebViewInternalClearDataFunction::ClearDataDone() {
   Release();  // Balanced in RunAsync().
   SendResponse(true);
 }
 
 }  // namespace extensions